Skip to content

Conversation

@anasfanani
Copy link
Contributor

@anasfanani anasfanani commented Oct 14, 2025

Description

Fix for #470

Type of Change

  • New module
  • New template
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Module Information

Path: registry/[namespace]/modules/[module-name]
New version: v1.0.0
Breaking change: [ ] Yes [ ] No

Template Information

Path: registry/[namespace]/templates/[template-name]

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun fmt)
  • Changes tested locally

Related Issues

@DevelopmentCats
Copy link
Contributor

DevelopmentCats commented Oct 14, 2025

@anasfanani

Can you look at #479 and implement the trailing slash removal using the locals that I did?

I will close my PR and merge yours instead 😄

It appears we were both working in parallel

@DevelopmentCats DevelopmentCats mentioned this pull request Oct 14, 2025
9 tasks
@anasfanani anasfanani force-pushed the anasfanani/fix-pass-folder-variable branch from 3fb6f2b to f262ec3 Compare October 14, 2025 18:20
@anasfanani anasfanani force-pushed the anasfanani/fix-pass-folder-variable branch from f262ec3 to 20a2edc Compare October 14, 2025 18:22
@anasfanani
Copy link
Contributor Author

@DevelopmentCats

Sorry I dont know you already working on this , I already copy paste all your closed PR 😄.

@DevelopmentCats
Copy link
Contributor

@anasfanani The Failing CI is related to a bug introduced in goose nothing you need to deal with.

Once this is resolved, or My CI updates are approved I will merge this.

Thanks for the fix!

@matifali matifali merged commit 63cad25 into coder:main Oct 15, 2025
3 checks passed
@anasfanani anasfanani deleted the anasfanani/fix-pass-folder-variable branch October 16, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants