-
Notifications
You must be signed in to change notification settings - Fork 81
feat(module/coder-labs/amp): add mode flag and disable animation #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
waiting for the agentapi PRs to be merged |
|
@35C4n0r, please make the PR title more descriptive. It should also tell what module it is changing. |
|
@35C4n0r can you fill out the PR description? |
|
Also @35C4n0r this would be a minor version bump since you are adding an input. |
Removed section on automated dependency management, including details on weekly updates, integrated testing, auto-merge, and manual trigger.
|
@DevelopmentCats thanks for the review, resolved the comments. |
matifali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Except a nit.
| default_base_config = jsonencode({ | ||
| "amp.anthropic.thinking.enabled" = true | ||
| "amp.todos.enabled" = true | ||
| "amp.terminal.animation" = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice.
| variable "mode" { | ||
| type = string | ||
| description = "Set the agent mode (free, rush, smart) — controls the model, system prompt, and tool selection. Default: smart" | ||
| default = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we explicitly set it to smart?
Description
"amp.terminal.animation": false: This disables the animation.Type of Change
Module Information
Path:
registry/coder-labs/modules/ampNew version:
v2.1.0Breaking change: [ ] Yes [X] No
Testing & Validation
bun test)bun fmt)Related Issues