Skip to content

feat: parameter validation refactored to single function #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
May 7, 2025
Merged

feat: parameter validation refactored to single function #381

Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
875b316
validate input vales
Emyrk Apr 14, 2025
9bb9a1f
begin adding invalid unit tests
Emyrk Apr 14, 2025
6ee8b80
add more validation tests
Emyrk Apr 14, 2025
2cb01cc
add better error message
Emyrk Apr 15, 2025
5e19e2a
revert test removal'
Emyrk Apr 30, 2025
b6787b0
WIP
Emyrk Apr 30, 2025
aaf1a17
chore: refactor validation while still keeping it mostly the same
Emyrk May 1, 2025
7cf79d8
fixup test cases
Emyrk May 1, 2025
bb16d1e
fixup test cases
Emyrk May 1, 2025
506f1c9
add nan cases
Emyrk May 1, 2025
a0ccb6f
merge cases
Emyrk May 1, 2025
fe4b4d7
remove comment
Emyrk May 1, 2025
0ad4eb6
chore: distinguish unset vs set default and values
Emyrk May 1, 2025
62f36ea
add 2 validation modes
Emyrk May 1, 2025
247df4e
add commented block
Emyrk May 1, 2025
dd7af3b
move constant
Emyrk May 1, 2025
fbd613e
remove duped validation
Emyrk May 1, 2025
5ef834e
Test fixes
Emyrk May 1, 2025
3a36fbb
PR fixes
Emyrk May 2, 2025
22f12cb
rename Valid -> ValidateInput
Emyrk May 2, 2025
f7b9338
Merge remote-tracking branch 'origin/main' into stevenmasley/value_va…
Emyrk May 5, 2025
0fd96ee
remove validation modes
Emyrk May 5, 2025
9433b31
chore: use default path in error if sourced from default
Emyrk May 7, 2025
79d3bf7
chore: always use the path argument, not default path
Emyrk May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading