Skip to content

chore: replace PtrTo with ptr.Ref #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2024
Merged

chore: replace PtrTo with ptr.Ref #132

merged 1 commit into from
Nov 7, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Nov 5, 2024

we already import coder/coder into this repo, and it's nice to have one name for things across code bases

@aslilac aslilac requested a review from ethanndickson November 5, 2024 22:59
ethanndickson
ethanndickson approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@ethanndickson ethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not totally sure why we added PtrTo instead of importing ptr.Ref in the first place - I think maybe we were afraid of bringing in heavy imports cause it's in coderd? util/ptr doesn't import anything else so it's evidently fine 🤷

@aslilac aslilac merged commit 4b8a4b1 into main Nov 7, 2024
13 checks passed
@aslilac aslilac deleted the lilac/ptr-ref branch November 7, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanndickson ethanndickson ethanndickson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aslilac @ethanndickson