Skip to content

Fix version comparison logic for checking wildcard support in "coder ssh" #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Fix version comparison logic for checking wildcard support in "coder ssh" #446

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f86f18
Fix version comparison logic for checking wildcard support in "coder …
Mar 5, 2025
1fb1c70
changelog update
bcpeinhardt Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/featureSet.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,12 @@ describe("check version support", () => {
expect(featureSetForVersion(semver.parse(v)).proxyLogDirectory).toBeTruthy()
})
})
it("wildcard ssh", () => {
;["v1.3.3+e491217", "v2.3.3+e491217"].forEach((v: string) => {
expect(featureSetForVersion(semver.parse(v)).wildcardSSH).toBeFalsy()
})
;["v2.19.0", "v2.19.1", "v2.20.0+e491217", "v5.0.4+e491217"].forEach((v: string) => {
expect(featureSetForVersion(semver.parse(v)).wildcardSSH).toBeTruthy()
})
})
})
2 changes: 1 addition & 1 deletion src/featureSet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ export function featureSetForVersion(version: semver.SemVer | null): FeatureSet
// If this check didn't exist, VS Code connections would fail on
// older versions because of an unknown CLI argument.
proxyLogDirectory: (version?.compare("2.3.3") || 0) > 0 || version?.prerelease[0] === "devel",
wildcardSSH: (version?.compare("2.19.0") || 0) > 0 || version?.prerelease[0] === "devel",
wildcardSSH: (version ? version.compare("2.19.0") : -1) >= 0 || version?.prerelease[0] === "devel",
}
}