Skip to content

fix: handle agent parameter in URIs #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2025
Merged

fix: handle agent parameter in URIs #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b55679
fix: handle agent parameter in URIs
ethanndickson Jun 24, 2025
305d015
fixup
ethanndickson Jun 24, 2025
804d2fe
fixup
ethanndickson Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .git-blame-ignore-revs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# If you would like `git blame` to ignore commits from this file, run:
# git config blame.ignoreRevsFile .git-blame-ignore-revs

# chore: simplify prettier config (#528)
f785902f3ad20d54344cc1107285c2a66299c7f6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this?

Copy link
Member Author

@ethanndickson ethanndickson Jun 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the same file on coder/coder - it's just a convenient way to remove a formatting commit from git blame results. I noticed every line was blamed on #528. No longer the case after running git config blame.ignoreRevsFile .git-blame-ignore-revs

6 changes: 3 additions & 3 deletions src/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ export class Commands {
} else {
workspaceOwner = args[0] as string;
workspaceName = args[1] as string;
// workspaceAgent is reserved for args[2], but multiple agents aren't supported yet.
workspaceAgent = args[2] as string | undefined;
folderPath = args[3] as string | undefined;
openRecent = args[4] as boolean | undefined;
}
Expand Down Expand Up @@ -628,7 +628,7 @@ export class Commands {

const workspaceOwner = args[0] as string;
const workspaceName = args[1] as string;
const workspaceAgent = undefined; // args[2] is reserved, but we do not support multiple agents yet.
const workspaceAgent = args[2] as string;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openDevcontainer URIs must include the agent name to work properly, I believe, so this is string and not string | undefined.

const devContainerName = args[3] as string;
const devContainerFolder = args[4] as string;

Expand Down Expand Up @@ -748,7 +748,7 @@ async function openDevContainer(
baseUrl: string,
workspaceOwner: string,
workspaceName: string,
workspaceAgent: string | undefined,
workspaceAgent: string,
devContainerName: string,
devContainerFolder: string,
) {
Expand Down