Skip to content

Add confirmation prompt to workspace update action #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2025
Merged

Add confirmation prompt to workspace update action #557

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3322ae6
Add confirmation prompt to workspace update action
blink-so[bot] Jul 17, 2025
dfc10c1
Update warning text to use 'unsaved work' instead of 'unsaved data'
blink-so[bot] Jul 18, 2025
9432181
Update warning text to match coder/coder wording
blink-so[bot] Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,14 +654,15 @@ export class Commands {
if (!this.workspace || !this.workspaceRestClient) {
return;
}
const action = await this.vscodeProposed.window.showInformationMessage(
const action = await this.vscodeProposed.window.showWarningMessage(
"Update Workspace",
{
useCustom: true,
modal: true,
detail: `Update ${this.workspace.owner_name}/${this.workspace.name} to the latest version?`,
detail: `Update ${this.workspace.owner_name}/${this.workspace.name} to the latest version?\n\nUpdating will restart your workspace and stop any running processes that may result in loss of unsaved work.`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me "that" implies the stopping of processes results in the loss of work, but really the restart is what does it. "And" might be a bit better, although "and" could also be interpreted this way so idk.

But this does match the wording used in coder/coder more: "Updating will restart your workspace which stops any running processes and may result in the loss of unsaved work."

},
"Update",
"Cancel",
);
if (action === "Update") {
await this.workspaceRestClient.updateWorkspaceVersion(this.workspace);
Expand Down