Skip to content

Conversation

@komar007
Copy link
Contributor

@komar007 komar007 commented Dec 1, 2025

This is a result of a small investigation into how to make protols work out of the box with the well-known protobuf types, even though it does not ship them. See NixOS/nixpkgs#465302.

The idea is to be able to configure, in compile time, a lowest-priority include path that a distro package could set to make sure, without compromising other sources of include paths, that protols can find the well-known types even when pkg-config and protobuf are missing from the environment and no paths have been manually configured via CLI or settings.

Please advise on the best name for the environment variable.

@coder3101
Copy link
Owner

I like the idea overall. Could you also document this change in README, env variable is fine whatever the nix systems use.

@komar007
Copy link
Contributor Author

komar007 commented Dec 2, 2025

I like the idea overall. Could you also document this change in README, env variable is fine whatever the nix systems use.

Thanks, I'll update the README.

As for the variable, there is no particular name in nix, I'll provide there whatever we settle upon in protols.

@komar007 komar007 force-pushed the fallback_include_path branch from 6d73d2d to 27c6f44 Compare December 2, 2025 23:00
Copy link
Collaborator

@asharkhan3101 asharkhan3101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@asharkhan3101 asharkhan3101 merged commit 358cc29 into coder3101:main Dec 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants