Clone kafka 18894

[DDShantanuBadmanji]

Delete this text and replace it with a detailed description of your change. The
PR title and body will become the squashed commit message.

If you would like to tag individuals, add some commentary, upload images, or
include other supplemental information that should not be part of the eventual
commit message, please use a separate comment.

If applicable, please include a summary of the testing strategy (including
rationale) for the proposed change. Unit and/or integration tests are expected
for any behavior change and system tests should be considered for larger
changes.

[coderabbitai]

Warning

Rate limit exceeded

@DDShantanuBadmanji has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 48 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between ed79212 and 5989a26.

📒 Files selected for processing (13)

• Vagrantfile (1 hunks)
• clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java (4 hunks)
• clients/src/main/java/org/apache/kafka/common/config/ConfigTransformer.java (3 hunks)
• clients/src/main/java/org/apache/kafka/common/config/provider/ConfigProvider.java (1 hunks)
• clients/src/test/java/org/apache/kafka/common/config/ConfigTransformerTest.java (5 hunks)
• clients/src/test/java/org/apache/kafka/common/config/provider/MonitorableConfigProvider.java (1 hunks)
• connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java (2 hunks)
• connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java (1 hunks)
• connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfigTransformer.java (3 hunks)
• connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java (3 hunks)
• connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConfigTransformerTest.java (5 hunks)
• connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java (5 hunks)
• connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/PluginsTest.java (4 hunks)

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch clone-KAFKA-18894

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello @DDShantanuBadmanji, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant architectural enhancement to Kafka Connect's ConfigProvider mechanism by integrating a Plugin wrapper and enabling metric reporting for ConfigProvider implementations. This refactoring standardizes how external configuration sources are managed and allows them to expose operational metrics, thereby improving the overall observability and manageability of Connect workers and connectors.

Highlights

• Metrics for Config Providers: ConfigProvider implementations can now optionally implement the Monitorable interface to expose metrics, significantly improving the observability of external configuration sources within Kafka Connect.
• Plugin Wrapper for Config Providers: ConfigProvider instances are now wrapped in a Plugin object, providing a standardized and extensible mechanism for managing and interacting with these providers, especially for integrating new functionalities like metrics.
• Refactoring of ConfigProvider Instantiation: The process of instantiating and configuring ConfigProviders has been updated across core components like AbstractConfig, MirrorMakerConfig, Worker, and WorkerConfigTransformer to seamlessly integrate with the new Plugin wrapper.
• Enhanced Testing for Monitoring: New and updated test cases have been added to ensure the correct behavior of MonitorableConfigProviders and the Plugin wrapper, including thorough verification of metric registration and the lifecycle of plugin methods.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[refacto-test]

Refacto is reviewing this PR. Please wait for the review comments to be posted.

[gemini-code-assist]

Code Review

This pull request introduces a Plugin wrapper for ConfigProvider instances, enabling them to register and expose metrics by implementing the Monitorable interface. The changes are consistently applied across various components, including AbstractConfig, ConfigTransformer, and Connect's Worker and MirrorMaker. The Worker is updated to pass its Metrics registry to the config providers, while other contexts that lack a metrics registry pass null, which is handled gracefully. The refactoring is clean, and the accompanying test changes, including new tests for MonitorableConfigProvider, are thorough and ensure the new functionality is working as expected. Overall, this is a solid improvement for observability of config providers.

[DDShantanuBadmanji]

/refacto-test

[DDShantanuBadmanji]

/refacto-test