Skip to content

Test pr 2, Don't merge #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
+13 −0
Open

Test pr 2, Don't merge #21

Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
aef5b14
test-file-added
shivaji-dev1 Aug 18, 2025
054f4be
update in hello.py
shivaji-dev1 Aug 18, 2025
c17f499
update 3
shivaji-dev1 Aug 18, 2025
133adf4
test-pr-don't-merge
shivaji-dev1 Aug 18, 2025
f64eeff
update hello.py 2.2
shivaji-dev1 Aug 18, 2025
9e76ef5
Update hello.py 2.3
shivaji-dev1 Aug 18, 2025
5c929e8
update 2.4
shivaji-dev1 Aug 18, 2025
216bbaa
Update app/hello.py
shivaji-dev1 Aug 21, 2025
5af800f
Update app/hello.py
shivaji-dev1 Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/hello.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
print("Hello world")
print("Hello world 2")
print("Hello world 3")

print("Test PR 2.1")
print("Test PR 2.2")
print("Test PR 2.3")
print("Test PR 2.4")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing error handling for print operations

Print operations can fail when stdout is unavailable (e.g., redirected to a closed pipe). Without error handling, this could cause script termination in non-interactive environments.

Suggested change
print("Hello world")
print("Hello world 2")
print("Hello world 3")
print("Test PR 2.1")
print("Test PR 2.2")
print("Test PR 2.3")
print("Test PR 2.4")
try:
print("Hello world")
print("Hello world 2")
print("Hello world 3")
print("Test PR 2.1")
print("Test PR 2.2")
print("Test PR 2.3")
print("Test PR 2.4")
except IOError as e:
import sys
sys.stderr.write(f"Error writing to stdout: {e}\n")
Standards
  • ISO-IEC-25010-Reliability-Fault-Tolerance
  • SRE-Error-Handling
  • DbC-Defensive-Programming

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing docstring and purpose explanation

The script lacks a docstring explaining its purpose and functionality. Without documentation, future developers will have difficulty understanding the intent and proper usage of this code.

Suggested change
print("Hello world")
print("Hello world 2")
print("Hello world 3")
print("Test PR 2.1")
print("Test PR 2.2")
print("Test PR 2.3")
print("Test PR 2.4")
#!/usr/bin/env python3
"""
Hello World Script
This script demonstrates basic print statements in Python.
It outputs multiple hello world messages followed by test messages.
"""
print("Hello world")
print("Hello world 2")
print("Hello world 3")
print("Test PR 2.1")
print("Test PR 2.2")
print("Test PR 2.3")
print("Test PR 2.4")
Standards
  • Clean-Code-Documentation
  • SOLID-Single-Responsibility

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensitive Data Exposure

The script outputs data directly to stdout without considering the execution context. In production environments, this could inadvertently expose sensitive information to logs or output streams that might be accessible to unauthorized users.

Suggested change
print("Hello world")
print("Hello world 2")
print("Hello world 3")
print("Test PR 2.1")
print("Test PR 2.2")
print("Test PR 2.3")
print("Test PR 2.4")
#!/usr/bin/env python3
import logging
# Configure logging with appropriate level
logging.basicConfig(level=logging.INFO, format='%(asctime)s - %(levelname)s - %(message)s')
logger = logging.getLogger(__name__)
# Use appropriate logging levels instead of print
logger.info("Hello world")
logger.info("Hello world 2")
logger.info("Hello world 3")
logger.info("Test PR 2.1")
logger.info("Test PR 2.2")
logger.info("Test PR 2.3")
logger.info("Test PR 2.4")
Standards
  • CWE-209
  • OWASP-A04

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Final Newline

File ends without a newline character, which can cause issues with text processing tools and version control systems. Standard text files should end with a newline to ensure proper concatenation and processing.

Suggested change
print("Test PR 2.4")
print("Test PR 2.4")
Standards
  • File-Format-Standard
  • POSIX-Compliance