Skip to content

Update main.py #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Update main.py #7

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
603f9ac
Update main.py
arvi18 Jul 14, 2025
d268a78
Update main.py
arvi18 Jul 14, 2025
72d92dc
Update main.py
arvi18 Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,16 @@
version="1.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Improvement: While replacing the wildcard CORS origin with a specific domain is a good security improvement, hardcoding the frontend URL (https://bubblesort.vercel.com) limits deployment flexibility. Consider using environment variables instead:

origins = os.getenv('ALLOWED_ORIGINS', 'https://bubblesort.vercel.com').split(',')

This would allow for different frontend URLs across environments without code changes.

)

# Add CORS middleware
# CORS setup
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Improvement: The PR correctly replaces the permissive CORS wildcard origin (["*"]) with a specific origin. However, the URL https://bubblesort.vercel.com appears to be a placeholder based on the comment. Please verify this is the correct production frontend URL before merging.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configuration Management: Consider moving the CORS origins list to environment variables or a configuration file instead of hardcoding it. This would make it easier to update in different environments without code changes.

origins = [
"http://localhost",
"http://localhost:3000", # React or frontend dev server
"https://your-frontend-domain.com" # Add your deployed frontend URL here
]

app.add_middleware(
CORSMiddleware,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation Issue: The comment suggests using ["*"] for all origins while noting it's not recommended for production. Since this PR is specifically implementing the security best practice of restricting origins, consider removing this comment to avoid confusion for future developers.

allow_origins=["*"], # Configure this properly for production
allow_origins=origins, # You can use ["*"] for all origins (not recommended for production)
allow_credentials=True,
allow_methods=["*"],
allow_headers=["*"],
Expand Down Expand Up @@ -51,4 +57,4 @@ async def root():
"auth": "/auth",
"protected": "/protected"
}
}
}