Skip to content

Create bubblesort python file #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Create bubblesort python file #8

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc674a1
Create bubblesort.py
visz11 Jul 15, 2025
5b3d6c3
Update and rename bubblesort.py to sorting_algorithms.py
arvi18 Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions bubblesort.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
def bubble_sort(arr):

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Add docstring and input validation.

The function lacks documentation and input validation. Consider adding a docstring to explain the behavior and validating the input parameter.

 def bubble_sort(arr):
+    """
+    Sorts a list in ascending order using the bubble sort algorithm.
+    
+    Args:
+        arr (list): The list to be sorted (modified in-place)
+    
+    Returns:
+        None: The function modifies the input list in-place
+    
+    Raises:
+        TypeError: If arr is not a list
+        ValueError: If arr is None
+    """
+    if arr is None:
+        raise ValueError("Input cannot be None")
+    if not isinstance(arr, list):
+        raise TypeError("Input must be a list")
+    if len(arr) <= 1:
+        return
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
def bubble_sort(arr):
def bubble_sort(arr):
"""
Sorts a list in ascending order using the bubble sort algorithm.
Args:
arr (list): The list to be sorted (modified in-place)
Returns:
None: The function modifies the input list in-place
Raises:
TypeError: If arr is not a list
ValueError: If arr is None
"""
if arr is None:
raise ValueError("Input cannot be None")
if not isinstance(arr, list):
raise TypeError("Input must be a list")
if len(arr) <= 1:
return
🤖 Prompt for AI Agents 
In bubblesort.py at lines 1 to 2, the bubble_sort function is missing a
docstring and input validation. Add a docstring that clearly describes the
function's purpose, parameters, and return value. Also, include input validation
to check that the argument is a list and contains comparable elements, raising
appropriate errors if the input is invalid.

# Outer loop to iterate through the list n times
for n in range(len(arr) - 1, 0, -1):

# Initialize swapped to track if any swaps occur
swapped = False

# Inner loop to compare adjacent elements
for i in range(n):
if arr[i] > arr[i + 1]:

# Swap elements if they are in the wrong order
arr[i], arr[i + 1] = arr[i + 1], arr[i]

# Mark that a swap has occurred
swapped = True

# If no swaps occurred, the list is already sorted
if not swapped:
break
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This function has a few style issues that should be addressed to align with Python best practices (PEP 8 for code style and PEP 257 for docstrings):

  • Missing Docstring: The function lacks a docstring explaining its purpose, arguments, and side effects.
  • Trailing Whitespace: Line 7 contains trailing whitespace.
  • Excessive Blank Lines: There are several unnecessary blank lines (e.g., lines 2, 5, 12, 15, 18) that make the code look sparse.

Addressing these will improve the code's readability and maintainability. I've provided a suggestion that fixes these points.

Suggested change
def bubble_sort(arr):
# Outer loop to iterate through the list n times
for n in range(len(arr) - 1, 0, -1):
# Initialize swapped to track if any swaps occur
swapped = False
# Inner loop to compare adjacent elements
for i in range(n):
if arr[i] > arr[i + 1]:
# Swap elements if they are in the wrong order
arr[i], arr[i + 1] = arr[i + 1], arr[i]
# Mark that a swap has occurred
swapped = True
# If no swaps occurred, the list is already sorted
if not swapped:
break
def bubble_sort(arr):
"""Sorts a list in-place using the bubble sort algorithm."""
# Outer loop to iterate through the list n times
for n in range(len(arr) - 1, 0, -1):
# Initialize swapped to track if any swaps occur
swapped = False
# Inner loop to compare adjacent elements
for i in range(n):
if arr[i] > arr[i + 1]:
# Swap elements if they are in the wrong order
arr[i], arr[i + 1] = arr[i + 1], arr[i]
# Mark that a swap has occurred
swapped = True
# If no swaps occurred, the list is already sorted
if not swapped:
break



# Sample list to be sorted
arr = [6,6,2]
print("Unsorted list is:")
print(arr)

bubble_sort(arr)

print("Sorted list is:")
print(arr)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The script's test/example code is executed at the top level of the module. This means that if this file is imported by another module (e.g., import bubblesort), this code will run, which is usually not the desired behavior. It's a standard Python best practice to place such code inside an if __name__ == "__main__": block. This ensures the code only runs when the script is executed directly, making the bubble_sort function reusable.

Suggested change
# Sample list to be sorted
arr = [6,6,2]
print("Unsorted list is:")
print(arr)
bubble_sort(arr)
print("Sorted list is:")
print(arr)
if __name__ == "__main__":
# Sample list to be sorted
arr = [6, 6, 2]
print("Unsorted list is:")
print(arr)
bubble_sort(arr)
print("Sorted list is:")
print(arr)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Wrap demonstration code in a main guard.

The demonstration code should be wrapped in a main guard to prevent execution when the module is imported.

-# Sample list to be sorted
-arr = [6,6,2]
-print("Unsorted list is:")
-print(arr)
-
-bubble_sort(arr)
-
-print("Sorted list is:")
-print(arr)
+if __name__ == "__main__":
+    # Sample list to be sorted
+    arr = [6, 6, 2]
+    print("Unsorted list is:")
+    print(arr)
+    
+    bubble_sort(arr)
+    
+    print("Sorted list is:")
+    print(arr)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Sample list to be sorted
arr = [6,6,2]
print("Unsorted list is:")
print(arr)
bubble_sort(arr)
print("Sorted list is:")
print(arr)
if __name__ == "__main__":
# Sample list to be sorted
arr = [6, 6, 2]
print("Unsorted list is:")
print(arr)
bubble_sort(arr)
print("Sorted list is:")
print(arr)
🤖 Prompt for AI Agents 
In bubblesort.py around lines 24 to 32, the demonstration code runs immediately
when the module is imported. To fix this, wrap the demonstration code inside an
if __name__ == "__main__": block. This will ensure the code only executes when
the script is run directly, not when imported as a module.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix inconsistent indentation.

The file has inconsistent indentation mixing 2 and 4 spaces. Python PEP 8 recommends using 4 spaces consistently.

 def bubble_sort(arr):
-  
-    # Outer loop to iterate through the list n times
-    for n in range(len(arr) - 1, 0, -1):
-        
-        # Initialize swapped to track if any swaps occur
-        swapped = False  
-
-        # Inner loop to compare adjacent elements
-        for i in range(n):
-            if arr[i] > arr[i + 1]:
-              
-                # Swap elements if they are in the wrong order
-                arr[i], arr[i + 1] = arr[i + 1], arr[i]
-                
-                # Mark that a swap has occurred
-                swapped = True
-        
-        # If no swaps occurred, the list is already sorted
-        if not swapped:
-            break
+    # Outer loop to iterate through the list n times
+    for n in range(len(arr) - 1, 0, -1):
+        # Initialize swapped to track if any swaps occur
+        swapped = False
+
+        # Inner loop to compare adjacent elements
+        for i in range(n):
+            if arr[i] > arr[i + 1]:
+                # Swap elements if they are in the wrong order
+                arr[i], arr[i + 1] = arr[i + 1], arr[i]
+                # Mark that a swap has occurred
+                swapped = True
+        
+        # If no swaps occurred, the list is already sorted
+        if not swapped:
+            break
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
def bubble_sort(arr):
# Outer loop to iterate through the list n times
for n in range(len(arr) - 1, 0, -1):
# Initialize swapped to track if any swaps occur
swapped = False
# Inner loop to compare adjacent elements
for i in range(n):
if arr[i] > arr[i + 1]:
# Swap elements if they are in the wrong order
arr[i], arr[i + 1] = arr[i + 1], arr[i]
# Mark that a swap has occurred
swapped = True
# If no swaps occurred, the list is already sorted
if not swapped:
break
# Sample list to be sorted
arr = [6,6,2]
print("Unsorted list is:")
print(arr)
bubble_sort(arr)
print("Sorted list is:")
print(arr)
def bubble_sort(arr):
# Outer loop to iterate through the list n times
for n in range(len(arr) - 1, 0, -1):
# Initialize swapped to track if any swaps occur
swapped = False
# Inner loop to compare adjacent elements
for i in range(n):
if arr[i] > arr[i + 1]:
# Swap elements if they are in the wrong order
arr[i], arr[i + 1] = arr[i + 1], arr[i]
# Mark that a swap has occurred
swapped = True
# If no swaps occurred, the list is already sorted
if not swapped:
break
# Sample list to be sorted
arr = [6, 6, 2]
print("Unsorted list is:")
print(arr)
bubble_sort(arr)
print("Sorted list is:")
print(arr)
🤖 Prompt for AI Agents 
In bubblesort.py from lines 1 to 32, the code uses inconsistent indentation with
a mix of 2 and 4 spaces. To fix this, update all indentation to use 4 spaces
consistently throughout the entire file, following Python PEP 8 style
guidelines.