Skip to content

fix: Update blkio test to be compatible with finch CI #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
+7 −8
Merged

fix: Update blkio test to be compatible with finch CI #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions e2e/tests/container_create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (
"fmt"
"net/http"
"os"
"os/exec"
"path/filepath"
"strconv"
"strings"
Expand Down Expand Up @@ -803,15 +802,15 @@ func ContainerCreate(opt *option.Option, pOpt util.NewOpt) {
dummyDev2 := "/dev/dummy-zero2"

// Create dummy devices (major number 1 for char devices)
err := exec.Command("mknod", dummyDev1, "c", "1", "5").Run()
Expect(err).Should(BeNil())
err = exec.Command("mknod", dummyDev2, "c", "1", "6").Run()
Expect(err).Should(BeNil())
mknodOpt1, _ := pOpt([]string{"mknod", dummyDev1, "c", "1", "5"})
command.Run(mknodOpt1)
mknodOpt2, _ := pOpt([]string{"mknod", dummyDev2, "c", "1", "6"})
command.Run(mknodOpt2)

// Cleanup dummy devices after test
defer func() {
exec.Command("rm", "-f", dummyDev1).Run()
exec.Command("rm", "-f", dummyDev2).Run()
rmOpt, _ := pOpt([]string{"rm", "-f", dummyDev1, dummyDev2})
command.Run(rmOpt)
}()

// define options
Expand Down Expand Up @@ -877,7 +876,7 @@ func ContainerCreate(opt *option.Option, pOpt util.NewOpt) {
// inspect container
resp := command.Stdout(opt, "inspect", testContainerName)
var inspect []*dockercompat.Container
err = json.Unmarshal(resp, &inspect)
err := json.Unmarshal(resp, &inspect)
Expect(err).Should(BeNil())
Expect(inspect).Should(HaveLen(1))

Expand Down
Loading