🌐 英語話者向けに統計ページの英語版を実装 #1706
Merged
🌐 英語話者向けに統計ページの英語版を実装 #1706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- /english/stats ルートを追加 - StatsController に言語判定機能を追加（@lang パラメータ） - グラフタイトル、凡例、軸ラベルを英語対応 - ページ内のすべてのテキストを条件分岐で英語化 - 都道府県名の英語表記に対応（Hokkaido, Tokyo など） - 言語切り替えリンクを各ページの冒頭に追加 既存のコードパターンを活用し、DRY原則に従った最小限の実装。 将来的なi18n導入を見据えた設計となっている。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 ✨ https://coderdojo.jp/english/stats
既存のコードパターンを活用し、DRY原則に従った最小限の実装で、将来的なi18n導入を見据えた設計となっています。
cf. https://gist.github.com/yasulab/23b8f2889f1c37cd5000d0939792013e