Skip to content

fix: フッターのリンク先とアイコンを修正 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 12, 2025
Merged

fix: フッターのリンク先とアイコンを修正 #15

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f720fd8
fix: footer links and styles
mucho613 Aug 11, 2025
e87aeac
fix: icon color, links
mucho613 Aug 12, 2025
06e952b
fix: x site property name in config.yml
mucho613 Aug 12, 2025
469198b
fix: remove hover effect
mucho613 Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions _config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ venue: 久留米シティプラザ
map: https://maps.app.goo.gl/4jicdzYEBzjtHd916

twitter: DojoConJapan
facebook: DojoConJapan
facebook: dojoconjapan
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 大文字・小文字を厳密に合わせた
  • 現在の正しい URL https://www.facebook.com/dojoconjapan/
  • 古い指定 -/DojoConJapan/ でアクセスした場合は 302 Found で、-/dojoconjapan/ に飛ばされる

email: [email protected]
youtube: UCX3tz875ZDtU85rFkYuwl5w
court:
contact: https://forms.gle/7wSMSLEmjc4ucVoHA
court:
contact: https://forms.gle/t9ctDcuZZ8cqqFtR6
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2025年用の問い合わせフォーム(https://forms.gle/t9ctDcuZZ8cqqFtR6)に変更

registration: https://dojocon-japan.doorkeeper.jp/events/176163

# Build settings
Expand Down
9 changes: 4 additions & 5 deletions _includes/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,19 @@
<img src="/img/2025/common/footer-logo.png" alt="DojoCon Japan 2025 Inspire Next." />
</div>
<div class="footer-social">
<a href="https://twitter.com/{{ site.twitter }}" target="_blank" rel="noopener" class="social-x" aria-label="X">
<a href="https://x.com/{{ site.x }}" target="_blank" rel="noopener" class="social-x" aria-label="X">
<i class="fa-brands fa-x-twitter" style="color:#000000;"></i>
</a>
<a href="https://www.facebook.com/{{ site.facebook }}" target="_blank" rel="noopener" class="social-facebook" aria-label="Facebook">
<i class="fa-brands fa-facebook" style="color:#3b5998;"></i>
<i class="fa-brands fa-facebook" style="color:#0866ff;"></i>
</a>
<a href="https://www.youtube.com/channel/{{ site.youtube }}" target="_blank" rel="noopener" class="social-youtube" aria-label="YouTube">
<i class="fa-brands fa-youtube" style="color:#ff0000;"></i>
<i class="fa-brands fa-youtube" style="color:#ff0033;"></i>
</a>
</div>
<nav class="footer-links">
<a href="/">ホーム</a>
<a href="/code-of-conduct">行動規範</a>
<a href="/sitemap">サイトマップ</a>
<a href="/code-of-conduct/">行動規範</a>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • URI は /code-of-conduct/index.html
  • GitHub Pages 上では、/code-of-conduct （/ 無し）でアクセスするとリダイレクトが挟んで /code-of-conduct/ が開く
  • リダイレクトを挟まずに遷移できるよう / を追加

<a href="/privacy">プライバシーポリシー</a>
<a href="{{site.contact}}" target="_blank">お問い合わせ</a>
</nav>
Expand Down
19 changes: 11 additions & 8 deletions _sass/includes/footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,22 +14,25 @@
}

.footer-social {
display: flex;
justify-content: center;
margin-bottom: 24px;
column-gap: 28px;

a {
display: inline-block;
margin: 0 14px;
font-size: 2.2rem;
color: #000;
width: 48px;
height: 48px;
width: 52px;
height: 52px;
line-height: 48px;
border-radius: 50%;
background: #ffffff;
transition: background 0.2s, color 0.2s;
border-bottom: 4px solid transparent;
transition: border-color 0.2s;
display: flex;
align-items: center;
justify-content: center;

&:hover {
background: $hover-color;
border-color: $hover-color;
color: #fff;
}
}
Expand Down