change: footerのスタイルを変更 #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takusandayooo
commented
Aug 4, 2025
| <a href="/code-of-conduct">行動規範</a> | ||
| <a href="/sitemap">サイトマップ</a> | ||
| <a href="/privacy">プライバシーポリシー</a> | ||
| <a href="{{site.contact}}" target="_blank">お問い合わせ</a> |
There was a problem hiding this comment.
お問い合わせのリンクは、お問い合わせGoogleフォームにした。
| <nav class="footer-links"> | ||
| <a href="/">ホーム</a> | ||
| <a href="/code-of-conduct">行動規範</a> | ||
| <a href="/sitemap">サイトマップ</a> |
There was a problem hiding this comment.
サイトマップのページが現状ないので、/sitemapとしておいた。
Fukusan64
reviewed
Aug 4, 2025
_sass/includes/footer.scss
Outdated
| @@ -1,74 +1,81 @@ | |||
| @use '../global/variables' as *; | |||
| $footer-link-hover: #7cc224; | |||
There was a problem hiding this comment.
これは興味本位の質問ですが、この色ってどこから持ってきた色ですか？
There was a problem hiding this comment.
この色ですが、どれを使えば良いか分からなかったので、ロゴの「Inspire Next.」の色に近いものを使っています。
セルフレビュー時に、そのことを書いておくべきでした。すみません🙇♀️
将来的にホバー時の色は統一されると思うので、variables.scssに追加するのが良いと思いました。
There was a problem hiding this comment.
042ed88 こちらでvariables.scssからホバーした際の色を参照するようにしました。
現状は、黄色にしていますが今後変更する予定です。
Fukusan64
reviewed
Aug 4, 2025
Fukusan64
approved these changes
Aug 4, 2025
|
Approveしました！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
フッターのデザインを適応しました。
↓変更後のデザイン