Fix: CI テスト実行時の環境変数エラーを修正 #257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
CI でのテスト実行時に環境変数が見つからずエラーになる問題を修正しました。
問題
bundle exec rake test
実行時にENV.fetch('SACLOUD_ACCESS_TOKEN')
で KeyError が発生解決策
ENV.fetch
の第2引数にデフォルト値を設定することで、環境変数がない場合でもテストが実行可能になります。なぜこの解決策が優れているか
ENV.fetch
の標準機能を活用なぜダミートークンで動作するか
現在のテスト(
ip_validation_test.rb
)は:そのため、
ENV.fetch
を満足させる値があれば十分です。実際の API 操作時には適切な認証エラーが発生するため、セキュリティ上の問題はありません。テスト結果
変更内容
scripts/sakura_server_user_agent.rb
: ENV.fetch にデフォルト値を追加(2行)