Deploy the bundled NSTemplateTiers using SSA#1185
Deploy the bundled NSTemplateTiers using SSA#1185metlos merged 4 commits intocodeready-toolchain:masterfrom
Conversation
| if !canUpdate { | ||
| if err := client.Create(ctx, toEnsure); err != nil && !apierrors.IsAlreadyExists(err) { | ||
| return false, err | ||
| } | ||
| return true, nil | ||
| } | ||
| applyCl := commonclient.NewApplyClient(client) | ||
| return applyCl.ApplyObject(ctx, toEnsure, commonclient.ForceUpdate(true)) |
There was a problem hiding this comment.
Just to clarify the original code - the purpose of the "canUpdate" parameter was to ensure immutability of the TierTemplates - they should be created only, not updated.
However, this requirement will go away as soon as we finish the NSTemplateTier refactoring effort, so it's probably fine to remove this check.
Also, all other tests should verify that there is no TierTemplate that would be updated
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, MatousJobanek, metlos The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
/retest |
Codecov ReportAttention: Patch coverage is
❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## master #1185 +/- ##
==========================================
- Coverage 71.21% 71.10% -0.12%
==========================================
Files 82 82
Lines 7977 8008 +31
==========================================
+ Hits 5681 5694 +13
- Misses 2092 2107 +15
- Partials 204 207 +3
🚀 New features to boost your workflow:
|
3 participants
This uses SSA to deploy the bundled NSTemplateTiers.
Related PRs:
JIRA: https://issues.redhat.com/browse/SANDBOX-1339