update controller gen version to v0.17.3 in crds #1204

fbm3307 · 2025-09-24T13:07:51Z

The sigs.k8s.io/controller-tools is at v0.17.3 in go.mod in api and other places so updating the crds to use the same version.

I updated this by running make generate from master branch in API

Summary by CodeRabbit

Chores
- Updated CRD metadata annotations to reflect controller-gen v0.17.3 across all Toolchain resources.
- No schema, API, or behavioral changes; this is a tooling/metadata alignment only.
- No user-facing changes or actions required.

Signed-off-by: Feny Mehta <[email protected]>

coderabbitai · 2025-09-24T13:08:00Z

Walkthrough

Bumps the controller-gen.kubebuilder.io/version annotation from v0.17.2 to v0.17.3 across multiple Toolchain CRD base YAMLs under config/crd/bases/. No schema, structure, or API changes.

Changes

Cohort / File(s)	Summary
CRD controller-gen annotation bump `config/crd/bases/toolchain.dev.openshift.com_*` (bannedusers.yaml, masteruserrecords.yaml, notifications.yaml, nstemplatetiers.yaml, proxyplugins.yaml, socialevents.yaml, spacebindingrequests.yaml, spacebindings.yaml, spaceprovisionerconfigs.yaml, spacerequests.yaml, spaces.yaml, tiertemplaterevisions.yaml, tiertemplates.yaml, toolchainclusters.yaml, toolchainconfigs.yaml, toolchainstatuses.yaml, usersignups.yaml, usertiers.yaml)	Update metadata.annotations[`controller-gen.kubebuilder.io/version`] from v0.17.2 to v0.17.3 in each listed CRD file.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

SANDBOX-1357: update kube & openshift dependencies to 4.19 #1196 — Previous bump of the same CRD annotation version (v0.16.5 → v0.17.2) on these files.

Suggested reviewers

xcoulon
MatousJobanek
alexeykazakov

Poem

A hop, a skip, a version zing—
From .2 to .3, a tidy spring.
CRDs all line in neat parade,
Annotations primped, upgrades made.
Thump-thump! my paws approve the scene—
Small hops make gardens evergreen. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "update controller gen version to v0.17.3 in crds" succinctly and accurately summarizes the primary change in the PR (bumping the controller-gen/Kubebuilder annotation in CRD files to v0.17.3) and aligns with the PR objectives and file-level summaries, making the intent clear to reviewers scanning history.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between efb6916 and 5dcffda.

📒 Files selected for processing (18)

config/crd/bases/toolchain.dev.openshift.com_bannedusers.yaml (1 hunks)
config/crd/bases/toolchain.dev.openshift.com_masteruserrecords.yaml (1 hunks)
config/crd/bases/toolchain.dev.openshift.com_notifications.yaml (1 hunks)
config/crd/bases/toolchain.dev.openshift.com_nstemplatetiers.yaml (1 hunks)
config/crd/bases/toolchain.dev.openshift.com_proxyplugins.yaml (1 hunks)
config/crd/bases/toolchain.dev.openshift.com_socialevents.yaml (1 hunks)
config/crd/bases/toolchain.dev.openshift.com_spacebindingrequests.yaml (1 hunks)
config/crd/bases/toolchain.dev.openshift.com_spacebindings.yaml (1 hunks)
config/crd/bases/toolchain.dev.openshift.com_spaceprovisionerconfigs.yaml (1 hunks)
config/crd/bases/toolchain.dev.openshift.com_spacerequests.yaml (1 hunks)
config/crd/bases/toolchain.dev.openshift.com_spaces.yaml (1 hunks)
config/crd/bases/toolchain.dev.openshift.com_tiertemplaterevisions.yaml (1 hunks)
config/crd/bases/toolchain.dev.openshift.com_tiertemplates.yaml (1 hunks)
config/crd/bases/toolchain.dev.openshift.com_toolchainclusters.yaml (1 hunks)
config/crd/bases/toolchain.dev.openshift.com_toolchainconfigs.yaml (1 hunks)
config/crd/bases/toolchain.dev.openshift.com_toolchainstatuses.yaml (1 hunks)
config/crd/bases/toolchain.dev.openshift.com_usersignups.yaml (1 hunks)
config/crd/bases/toolchain.dev.openshift.com_usertiers.yaml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: GolangCI Lint
GitHub Check: Build & push operator bundles for e2e tests

🔇 Additional comments (18)

config/crd/bases/toolchain.dev.openshift.com_usersignups.yaml (1)

6-6: Annotation bump to v0.17.3 — LGTM

Consistent with the stated alignment; no functional changes.

config/crd/bases/toolchain.dev.openshift.com_spacerequests.yaml (1)

6-6: Annotation bump to v0.17.3 — LGTM

No schema diffs; metadata-only update.

config/crd/bases/toolchain.dev.openshift.com_masteruserrecords.yaml (1)

6-6: Annotation bump to v0.17.3 — LGTM

Aligned with other CRDs; nothing else changed.

config/crd/bases/toolchain.dev.openshift.com_socialevents.yaml (1)

6-6: Annotation bump to v0.17.3 — LGTM

Annotation-only change as intended.

config/crd/bases/toolchain.dev.openshift.com_spaceprovisionerconfigs.yaml (1)

6-6: Annotation bump to v0.17.3 — LGTM

No CRD schema modifications.

config/crd/bases/toolchain.dev.openshift.com_tiertemplates.yaml (1)

6-6: Annotation bump to v0.17.3 — LGTM

Consistent across CRDs; metadata-only.

config/crd/bases/toolchain.dev.openshift.com_spaces.yaml (1)

6-6: Annotation bump to v0.17.3 — LGTM

No functional impact; aligns with controller-tools version.

config/crd/bases/toolchain.dev.openshift.com_toolchainclusters.yaml (1)

6-6: Annotation bump to v0.17.3 — LGTM

Repository grep confirms all controller-gen.kubebuilder.io/version annotations in the CRD manifests are v0.17.3; no schema changes observed.

config/crd/bases/toolchain.dev.openshift.com_usertiers.yaml (1)

6-6: LGTM. Annotation-only bump.

config/crd/bases/toolchain.dev.openshift.com_spacebindingrequests.yaml (1)

6-6: LGTM. Annotation-only bump.

config/crd/bases/toolchain.dev.openshift.com_spacebindings.yaml (1)

6-6: LGTM. Annotation-only bump.

config/crd/bases/toolchain.dev.openshift.com_proxyplugins.yaml (1)

6-6: LGTM. Annotation-only bump.

config/crd/bases/toolchain.dev.openshift.com_bannedusers.yaml (1)

6-6: LGTM. Annotation-only bump.

config/crd/bases/toolchain.dev.openshift.com_toolchainstatuses.yaml (1)

6-6: LGTM. Annotation-only bump.

config/crd/bases/toolchain.dev.openshift.com_notifications.yaml (1)

6-6: LGTM. Annotation-only bump.

config/crd/bases/toolchain.dev.openshift.com_nstemplatetiers.yaml (1)

6-6: LGTM — controller-gen annotations updated to v0.17.3
All files under config/crd/bases/*.yaml report v0.17.3; no v0.17.2 occurrences remain.

config/crd/bases/toolchain.dev.openshift.com_tiertemplaterevisions.yaml (1)

6-6: Consistent controller-gen version bump — LGTM

Matches the PR’s goal to align to v0.17.3. No other CRD changes observed.

If not already done, regenerate CRDs with controller-tools v0.17.3 and ensure no uncommitted diffs remain after generation.

config/crd/bases/toolchain.dev.openshift.com_toolchainconfigs.yaml (1)

6-6: Annotation bump to v0.17.3 — LGTM

Verified: all config/crd/bases/* files report controller-gen.kubebuilder.io/version: v0.17.3 (unique); no bundle/OLM directory detected to check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

rsoaresd

🚀

rsoaresd · 2025-09-24T16:22:18Z

/retest

failed due to missing configuration for sandbox ui e2e tests

openshift-ci · 2025-09-24T17:46:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, fbm3307, rajivnathan, rsoaresd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [alexeykazakov,fbm3307,rajivnathan,rsoaresd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sonarqubecloud · 2025-09-25T13:00:31Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov · 2025-09-26T06:27:21Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.95%. Comparing base (efb6916) to head (f12f60c).
⚠️ Report is 2 commits behind head on master.

❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1204      +/-   ##
==========================================
- Coverage   70.98%   70.95%   -0.03%     
==========================================
  Files          83       83              
  Lines        8064     8064              
==========================================
- Hits         5724     5722       -2     
- Misses       2131     2133       +2     
  Partials      209      209

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

update controller gen version to v0.17.3 in crds

5dcffda

Signed-off-by: Feny Mehta <[email protected]>

openshift-ci bot requested review from rajivnathan and rsoaresd September 24, 2025 13:07

openshift-ci bot added the approved label Sep 24, 2025

rsoaresd approved these changes Sep 24, 2025

View reviewed changes

alexeykazakov approved these changes Sep 24, 2025

View reviewed changes

rajivnathan approved these changes Sep 24, 2025

View reviewed changes

Merge branch 'master' into fixcontrollergenversion

f12f60c

fbm3307 merged commit db394cd into codeready-toolchain:master Sep 26, 2025
13 of 15 checks passed

coderabbitai bot mentioned this pull request Dec 17, 2025

SANDBOX-1465: update kube & openshift dependencies to 4.20 #1226

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

update controller gen version to v0.17.3 in crds #1204

update controller gen version to v0.17.3 in crds #1204

Uh oh!

fbm3307 commented Sep 24, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Sep 24, 2025 •

edited

Loading

Uh oh!

rsoaresd left a comment

Uh oh!

rsoaresd commented Sep 24, 2025

Uh oh!

openshift-ci bot commented Sep 24, 2025

Uh oh!

sonarqubecloud bot commented Sep 25, 2025

Uh oh!

Uh oh!

codecov bot commented Sep 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

update controller gen version to v0.17.3 in crds #1204

update controller gen version to v0.17.3 in crds #1204

Uh oh!

Conversation

fbm3307 commented Sep 24, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

rsoaresd left a comment

Choose a reason for hiding this comment

Uh oh!

rsoaresd commented Sep 24, 2025

Uh oh!

openshift-ci bot commented Sep 24, 2025

Uh oh!

sonarqubecloud bot commented Sep 25, 2025

Quality Gate passed

Uh oh!

Uh oh!

codecov bot commented Sep 26, 2025

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fbm3307 commented Sep 24, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 24, 2025 •

edited

Loading