SANDBOX-1392: Api pair-Drop dependency on Che instance

[fbm3307]

This PR is to remove the che related unused code from crds

Related PRs:

• Api : SANDBOX-1392: Drop dependency on Che instance api#488
• Member-operator : SANDBOX-1392: API-Pair Drop dependency on Che instance member-operator#704

Summary by CodeRabbit

• Refactor
  • Removed Che/CRW integration from host and per-member configurations.
  • Eliminated Che-related fields from status reporting, including the Che dashboard URL and member Che status details.
  • Tools or configs that referenced Che/CRW settings or status fields will no longer detect or use them.

[coderabbitai]

Walkthrough

Removed all Che/CRW-related configuration and status fields from ToolchainConfig and ToolchainStatus CRD schemas; no other fields or functionality were added.

Changes

Cohort / File(s)	Summary
ToolchainConfig CRD schema config/crd/bases/toolchain.dev.openshift.com_toolchainconfigs.yaml	Deleted entire che/CRW configuration blocks from host defaults and per-member cluster configs (all nested fields including routes, namespace, secret keys, ref, userDeletionEnabled, required, etc.).
ToolchainStatus CRD schema config/crd/bases/toolchain.dev.openshift.com_toolchainstatuses.yaml	Removed che status object from spec.members[].memberStatus and removed cheDashboardURL from spec.routes.

Sequence Diagram(s)

(omitted — changes are schema removals only, no control-flow modifications)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• SANDBOX-1392: Drop dependency on Che instance #1202 — also removes Che-related configuration/status fields from CRDs and related code paths.

Suggested reviewers

• MatousJobanek
• rsoaresd
• xcoulon

Poem

I hopped through YAML, bold and spry,
Snipped Che’s leaves from low to high.
Fewer fields, a cleaner trail,
My whiskers twitch — config prevail! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title clearly indicates the removal of the Che dependency, which aligns with the main change of dropping Che configuration from CRDs, and the JIRA ticket provides traceability without obscuring the main intent.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 782b65f and 5abae33.

📒 Files selected for processing (1)

• config/crd/bases/toolchain.dev.openshift.com_toolchainstatuses.yaml (0 hunks)

💤 Files with no reviewable changes (1)

• config/crd/bases/toolchain.dev.openshift.com_toolchainstatuses.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: GolangCI Lint
• GitHub Check: Build & push operator bundles for e2e tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[MatousJobanek]

can you please also link the updated api as the go dependency? it looks like that there was some failure in the "check dependencies" workflow, so just to make sure that we don't depend on the field anywhere.

[MatousJobanek]

there is at least one place where it is still not cleaned - have you seen my comment here? codeready-toolchain/member-operator#701 (comment)

[fbm3307]

there is at least one place where it is still not cleaned - have you seen my comment here? codeready-toolchain/member-operator#701 (comment)

@MatousJobanek , yeah, i have the PR raised for it, will merge that first and then these toolchain-common and api and related PRs

[MatousJobanek]

Thanks, I have missed that in all the PRs opened recently 👍

[coderabbitai]

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details

{"name":"HttpError","status":500,"request":{"method":"PATCH","url":"https://api.github.com/repos/codeready-toolchain/host-operator/issues/comments/3337128413","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/0.0.0-development octokit-core.js/7.0.5 Node.js/24","authorization":"token [REDACTED]","content-type":"application/json; charset=utf-8"},"body":{"body":"<!-- This is an auto-generated comment: summarize by coderabbit.ai -->\n<!-- walkthrough_start -->\n\n## Walkthrough\nRemoved Che/CRW-related configuration blocks from the ToolchainConfig CRD and removed Che-related fields (including `cheDashboardURL` and `che` member status) from the ToolchainStatus CRD. No other fields were added or structural changes made.\n\n## Changes\n| Cohort / File(s) | Summary |\n|---|---|\n| **ToolchainConfig CRD schema**<br>`config/crd/bases/toolchain.dev.openshift.com_toolchainconfigs.yaml` | Removed all Che/CRW configuration blocks from host defaults and per-member configurations (deleted `che` property and all nested fields such as routes, namespace, secret keys, ref, userDeletionEnabled, required, etc.). |\n| **ToolchainStatus CRD schema**<br>`config/crd/bases/toolchain.dev.openshift.com_toolchainstatuses.yaml` | Removed Che-related fields from the ToolchainStatus schema: deleted `spec.routes.cheDashboardURL` and removed `spec.members[].memberStatus.che` (including its nested status/conditions). |\n\n## Sequence Diagram(s)\n\n## Estimated code review effort\n🎯 2 (Simple) | ⏱️ ~10 minutes\n\n## Possibly related PRs\n- codeready-toolchain/host-operator#1202 — Also removes Che/CRW-related fields (Che dashboard route and member status handling); closely related schema-level changes.\n\n## Suggested reviewers\n- rsoaresd  \n- MatousJobanek  \n- alexeykazakov  \n- xcoulon\n\n## Poem\n> I hopped through YAML, tidy and spry,  \n> Snipped Che’s branches—off they fly.  \n> Schemas lighter, no routes to chase,  \n> A carrot seal, in hopping grace. 🥕\n\n<!-- walkthrough_end -->\n\n\n<!-- pre_merge_checks_walkthrough_start -->\n\n## Pre-merge checks and finishing touches\n<details>\n<summary>✅ Passed checks (3 passed)</summary>\n\n|     Check name     | Status   | Explanation                                                                                                                                                                                                                      |\n| :----------------: | :------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n|  Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled.                                                                                                                                                                      |\n|     Title Check    | ✅ Passed | The title succinctly conveys the primary change—dropping the dependency on the Che instance—and includes the issue key for traceability, which directly aligns with the removal of Che configuration blocks described in the PR. |\n| Docstring Coverage | ✅ Passed | No functions found in the changes. Docstring coverage check skipped.                                                                                                                                                             |\n\n</details>\n\n<!-- pre_merge_checks_walkthrough_end -->\n\n<!-- finishing_touch_checkbox_start -->\n\n<details>\n<summary>✨ Finishing touches</summary>\n\n<details>\n<summary>🧪 Generate unit tests (beta)</summary>\n\n- [ ] <!-- {\"checkboxId\": \"f47ac10b-58cc-4372-a567-0e02b2c3d479\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} -->   Create PR with unit tests\n- [ ] <!-- {\"checkboxId\": \"07f1e7d6-8a8e-4e23-9900-8731c2c87f58\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} -->   Post copyable unit tests in a comment\n\n</details>\n\n</details>\n\n<!-- finishing_touch_checkbox_end -->\n\n\n---\n\n<details>\n<summary>📜 Recent review details</summary>\n\n**Configuration used**: CodeRabbit UI\n\n**Review profile**: CHILL\n\n**Plan**: Pro\n\n<details>\n<summary>📥 Commits</summary>\n\nReviewing files that changed from the base of the PR and between 782b65fb8e733e8cb288cc4861b61b6982ed471a and 4f443d8de7f971b4a541e80f360e14f19551862a.\n\n</details>\n\n<details>\n<summary>📒 Files selected for processing (1)</summary>\n\n* `config/crd/bases/toolchain.dev.openshift.com_toolchainstatuses.yaml` (0 hunks)\n\n</details>\n\n<details>\n<summary>💤 Files with no reviewable changes (1)</summary>\n\n* config/crd/bases/toolchain.dev.openshift.com_toolchainstatuses.yaml\n\n</details>\n\n<details>\n<summary>⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)</summary>\n\n* GitHub Check: GolangCI Lint\n* GitHub Check: Build & push operator bundles for e2e tests\n\n</details>\n\n</details>\n\n<!-- tips_start -->\n\n---\n\nThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n<details>\n<summary>❤️ Share</summary>\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n</details>\n\n<sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub>\n\n<!-- tips_end -->\n\n<!-- internal state start -->\n\n\n<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrKPR1AGxJcAygEEAOQARACEAeQANMABGAGYATgAmLj9uHW5tCjAginxuSCVuMiUMBnl8LABhWBIUDERcTAZayAMAxwFKLmjEgAYANkhWgFUbABkuWFxcbkQOAHp5onVYbAENJmZ5piUKEjRaWTACfA8GWG0Medh8BrA85QIKee5sDw95noGhg2HELsgADMBMxYrFegB2H4+fDYCjNSACKilWBcRCYWgCfAADziSTQaRuDR+0GcpFwiOR5y4zDQDUo0MauGwc34RSwrRsJAk8BIAHdKKyKIh8M5pPRWmMVCQPKyCbx8FIJQZKntqHR0JxIH1EgBWMC9eJgRL9aCQjiJAAsHF6AA4AFpGILSBgUeDccQVDgGOCoWyQPbMRXSSDYDAsjUAA3OJEjYD2HnV9B2tUBuWYkEqNiCiA0kC5iZo9FsyD2gMoZGa9DF3qgqXgk2mswWSxWaw2LG2igrByOJzOF3gVwJ8Bebw+ltttoMUAAsiRmJ0sg8qE9GzM5otlrhVutNl3dvtDsd8Kdzpd5mxF5R7kVV/hnq93vMIb1LeZLJUWGwMLhkA4nBcIw52oWFEAAKUETASAAawDEhuAfItIB3ahNUgLw6QpCpam4RMEQaeB3gUX9LmQaMajjBMkwUJR0AwegPCHGCNTQBRWHYddmy3Ns907FM1WPftzyHS8FyXW9HgfMdn1faIzCQBxRG/dgwDBaIklifpoghRI81aKBgVBcEoTQBgYIwfA+S8WhSHoHdakU7ASAAGng8s9lKVisBIbEkHEDAiGsOwAAoiVwST7z4f0zC+RIAEp0FoWg9kQRAhyC1CKUDS4Mow/AGGoeAKjcjF7CZDUHJ4RMsAISA2AoUhgsgWKdSBeBhQpMqHKwBqmqq6jkOEwcMDATYgwwUq0lKhj6vEm8V1A6KbFzH4QIIFlIIEaC4NQjAWPoIywUhej6EsoaankC56GYRTKouCkh3g5pfw8cp2Q1EsNGAsBDAMEwoGKfhARwAhiDIR4NXGzieD4QQRDESQQzkWjlFUdQtB0fR/vAKBfWQVBMFBwhSHIVcoZU38uCoPl7EcWkXEReQBJUNRNG0XRfqMHHTAMJgMEBeAiG2ChaHmbb/kQeZhsuDQlAkDQHnqBBAU0TYAH0ZaHfnBaIXNZDQZgPG9AAiM2DAsSA/AASXBsmaIAhnyhB89AukIwuSDJUUJqSB2A62pqhIeYswAdRI3W4SKipEQ8Aq4LTFhEXwHcfdqcKChIQE0DeCl/kRmOysTjM7zAK8l0YDwWRoPgdaFqPPXqPMfCKBh4EFwr3lkNyqpjWGV1weQyrQYj1GQch6UO3kPFoZAQpY2QGDjtAYJsWEaACQ3XMgDAt8QDJmjc3I8BITe2Dc/O9gpPkVkYGo/FoW6MCsOlED5B9aAAaRIbu75IB+n5/EoLvNg39f5ljchGCgzovCNwAKK7wEDZGa9A9gAEdsAB0OomIgiUBR7EzrAjUYZdi1kgOFLQeAWBFQYKkBUEgR6nXgoWDUGclBmXEAwxuYlcBugYP+UQjdEAznsK3du8AGBWEoPOa8FBKhV3pHwHOBBECdxvINCmAt66rmKvUIwD9aDqF0SPN6PdfZMAoKlRCDE8pBxDjYUO8YZQ0XhoI0MDEGRVXLjefeohxEMEztnXOc8ypjx4DebxfAGFumjvUPBdJ4JezoG5bWVdDGBXQKPP8O9pDIUFjKWedRk6pwzmVSJPBqCwFzEYAI+Acm00BGGAuu8mKD34EojwNdd40Ajto2JkA+QJIOEoWgABufgGA3pp0zDUex4c65EAbro2O8dkD4NqIGYMtBvrcygHYsOvTFk6Jjkg+OiStlAnTOQ24XVZql3KQspZFRhEzl5nAwitJkIpngjyfkftASAiQlwechjHAGDNibH6YAjALJFmLCW0hpangHLLeWit2SIBVmrFgmtkUiXqEyCM+tDbG3BebS2Ns7aQ3oI7Zwzs76YFIC8z2FyqpBycSwqeBTkDF2mdAPFI0fCEuQFmII9gYy0jISy72vcahBDpLALEzhaCjDGO1Aplyk6+IYBoY+NBEBuRlPAJ+RUMlst9vKzFSrRaQFVQGdejkBYPk+bo76UBpX3VqH3fJM9NUZm1RoSJiAADaABdQN80KBCuoCyUqccMk31TmEieyEGgxqlvzQxQjyoUGwGIOEJAdm1P4A5Pgqiai0gZW7ZAYpYbSHYDsilnTHi6OQHVKqSgl7OFicgfAINfKIQoMhB8PA1hMQCf7cQ7sREADFp6oIXFsrgFESCWsVaKUWqrIxFMjAGvV0ht19sgJGflZ5BXCu3U9aMFRdZwvFnSRFWsMBy25OisgmL27YuYLis9ZFhXSA0AbI2kZZ3zvOUqZdMZL1YF3a3CNsiQ3hsidG5kiBD0gxPQKy4KGWTQePbC108KH1SyfS+hWSsP2qw7N+p9abUMAaAx4EDBh3niE+RTOiexfm0yzoCodwK6DwDBRCn6f0AZ+1mke5RJMIbk2TJTLUNM6aAXkCjFm6N2ZYy5uJ8a6h1bwFnurLjvIBS0HVmmodnMxO40gBCW0iQBD9F1MCW0JAIRghILaBgAhEhTgYAwSc2lHPREc/EezdBLQQmiGxbG4nLSAktJaWItBbRKAhICeIUWBCWjQLqS00RPO9EBFpXoJBojxY0rqXU0RbT9ESDFrmPMoC6dwPpwzxn+R0HVkDWLNneAkHVn1AbMZzKIHM40Sz2MDAAG8DBDBNkgWwIQ47mToF+Div4rA3LoCbLg2dZSuTm5AE2mLYQz2W/HWwu2gQj3+C5I7C3EBhCkJYgzJRrv7buw9wxtAbBhiCAVIVbpAqICDuZa7vDnL3fmz9v7GB3C4C8GDmCEPc2HZhwZuHzpVFug9Lo5HH3bvo+O0xfadBrZpWcogIH12zbQ5J1hZHXIHCdMQNd4NR2hizaGDz47I2YJnxILT7Hrp3SNxmaIFH9PecneFajqHnOecmwHTVWJtPkf2Bgu6Io9A9ndhsKzdQgBMAmQAgIgsAwBeCkB4ZTTsUDIDICoGyGgTbS6V0GJQtPBkUAwBlV3iv5sPiFkOEeyPBe06UDjsXujIW84AL5u+57zvnNRzLh64CbBHXgJfg7d/NujLJ5fE5lyrzAauM9wFqOIRHtQHD+e1oj5mFQpCyDbb7Xgxq6VVtIIAFAIUp5DSGa32hRiiVnKLVX2Qc6hpq8j30JpQ0khiqk5WoC8gQjt4WZfYahWm/z5Agc4BQA5iCmSPIW9QBm3wGouhhNuj1T8eccrApzRuZyj50egT0qq2Bd3n47qVTg8AY8M8vx6gDMGQywhw8oR1NkeQh9cJYAqB/hIBAAcAnrAqQ6kAFwCFAEGdQAofAEMc6JKG6fYX3QKRpG3fmGgbEXAHuOpY1ehL1RMN0NpMqQSFQIidQWQX/APY7D3IXDPb3Mgogf3ZPf/ZSLRI5AQm7A7P/E2IPZYFpMPLeWnavLwWPHnBPRXJPGXfndPY7AHfhXhWxYMKgUgUQ5PWXdNIvOQ0vbpYA47YtRpUobNQFEhIpWVRlADSAQwhoYHIKJgF7NAJqfnTXbXOgHgsQk2fgr3ZwYQiwmXBQkPDwZQtgCPAqPwjKNnRXOPI7UNenE2RMBoWwEXXHRuWnS0PLBIEgS0RIWgeIEgeIfoUrXoeohgXUeIYECEfoeLPUWIOzZzBLE0MLOreLCEeowY6IaIBgVLAQWgS0eosyZKCwworCWwLPaQk2csVLRIHoUQArAQJo2IAQAYWrJIXUCES0eIdo3UTEeIXLWgWIBgaIUrXUMrTo/oVLBgFzW0MLBLXUezRIQEZYgwXIprOtQbSgUgdWfnMbHrX6IAA= -->\n\n<!-- internal state end -->"},"request":{"retryCount":3,"retries":3,"retryAfter":16}},"cause":{}}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, fbm3307, MatousJobanek, rajivnathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek,alexeykazakov,fbm3307,rajivnathan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.98%. Comparing base (5ccd7f9) to head (6fc59f8).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1206      +/-   ##
==========================================
- Coverage   71.01%   70.98%   -0.03%     
==========================================
  Files          83       83              
  Lines        8069     8069              
==========================================
- Hits         5730     5728       -2     
- Misses       2130     2132       +2     
  Partials      209      209              

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.