-
Notifications
You must be signed in to change notification settings - Fork 70
update .govulncheck.yaml #1212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update .govulncheck.yaml #1212
Conversation
WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
MatousJobanek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, MatousJobanek, rsoaresd, xcoulon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bd01295
into
codeready-toolchain:master
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1212 +/- ##
==========================================
- Coverage 71.01% 70.84% -0.17%
==========================================
Files 83 83
Lines 8069 6483 -1586
==========================================
- Hits 5730 4593 -1137
+ Misses 2130 1681 -449
Partials 209 209 🚀 New features to boost your workflow:
|



Description
We are hitting a lot of vuns in govulncheck. This PR adds them to
.govulncheck.yamlto ignore them. This is just temporary since we will upgrade go version to 1.24 once we have our clusters using Openshift 4.20Related PR
codeready-toolchain/api#490
codeready-toolchain/toolchain-common#497
codeready-toolchain/member-operator#708
codeready-toolchain/registration-service#556
codeready-toolchain/toolchain-e2e#1219
kubesaw/ksctl#131
Summary by CodeRabbit