Skip to content

Conversation

@rsoaresd
Copy link
Contributor

@rsoaresd rsoaresd commented Nov 3, 2025

Description

We are hitting a lot of vuns in govulncheck. This PR adds them to .govulncheck.yaml to ignore them. This is just temporary since we will upgrade go version to 1.24 once we have our clusters using Openshift 4.20

Related PR

codeready-toolchain/api#490
codeready-toolchain/toolchain-common#497
codeready-toolchain/member-operator#708
codeready-toolchain/registration-service#556
codeready-toolchain/toolchain-e2e#1219
kubesaw/ksctl#131

Summary by CodeRabbit

  • Chores
    • Updated vulnerability configuration to manage specific security issues with designated suppression expiration dates.

@coderabbitai
Copy link

coderabbitai bot commented Nov 3, 2025

Walkthrough

The .govulncheck.yaml configuration file was updated to replace an empty ignored-vulnerabilities list with populated entries. Each entry contains a vulnerability ID, information URL, and silence-until timestamp for managing vulnerability suppressions.

Changes

Cohort / File(s) Summary
Configuration Update
\.govulncheck\.yaml
Replaced empty ignored-vulnerabilities list with multiple vulnerability entries, each containing ID, info URL, and silence-until timestamp for suppressing specific vulnerabilities until designated dates.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify each vulnerability ID and associated URLs are correct and up-to-date
  • Confirm silence-until timestamps are appropriate and justified
  • Ensure all required metadata fields are present for each vulnerability entry

Suggested labels

lgtm

Suggested reviewers

  • xcoulon
  • MatousJobanek

Poem

🐰 A config so tidy, now filled with its care,
Vulnerabilities hushed till the date we declare,
With IDs and timestamps, all neatly arranged,
Go forth with this wisdom—no pesky bugs changed! ✨

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title 'update .govulncheck.yaml' is directly related to the changeset, which specifically updates the .govulncheck.yaml configuration file by populating its ignored-vulnerabilities list with detailed vulnerability entries. The title accurately reflects the primary change being made, though it is quite generic and doesn't convey what specifically was updated within the file.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2025

Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, rsoaresd, xcoulon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,alexeykazakov,rsoaresd,xcoulon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bd01295 into codeready-toolchain:master Nov 4, 2025
15 checks passed
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.84%. Comparing base (2fc7ca6) to head (7a86ea7).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1212      +/-   ##
==========================================
- Coverage   71.01%   70.84%   -0.17%     
==========================================
  Files          83       83              
  Lines        8069     6483    -1586     
==========================================
- Hits         5730     4593    -1137     
+ Misses       2130     1681     -449     
  Partials      209      209              

see 77 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants