-
Notifications
You must be signed in to change notification settings - Fork 70
feat: add workato #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add workato #1214
Conversation
WalkthroughA new Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/crd/bases/toolchain.dev.openshift.com_toolchainconfigs.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: GolangCI Lint
- GitHub Check: Build & push operator bundles for e2e tests
| workatoWebHookURL: | ||
| description: |- | ||
| WorkatoWebHookURL is used by the UI to push events to Marketo for analytics purposes. | ||
| The webhook URL is unique per environment. | ||
| type: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Service name mismatch between field name and description.
The field is named workatoWebHookURL but the description refers to "Marketo" — these are different services (Workato is an integration platform; Marketo is a marketing automation platform). Given the PR title mentions "add workato", the description appears incorrect.
Apply this diff to correct the description:
workatoWebHookURL:
description: |-
- WorkatoWebHookURL is used by the UI to push events to Marketo for analytics purposes.
+ WorkatoWebHookURL is used by the UI to push events to Workato for analytics purposes.
The webhook URL is unique per environment.
type: string🤖 Prompt for AI Agents
In config/crd/bases/toolchain.dev.openshift.com_toolchainconfigs.yaml around
lines 410 to 414, the description for the field workatoWebHookURL incorrectly
refers to "Marketo"; update the description to reference Workato and clarify
intent (e.g., "Workato webhook URL used by the UI to push events for
analytics/integration purposes; the webhook URL is unique per environment").
Ensure the field name and description consistently mention Workato and retain
existing wording about uniqueness per environment and type string.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, mfrancisc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1214 +/- ##
==========================================
+ Coverage 70.83% 70.84% +0.01%
==========================================
Files 83 83
Lines 6483 6483
==========================================
+ Hits 4592 4593 +1
+ Misses 1682 1681 -1
Partials 209 209 🚀 New features to boost your workflow:
|



generated from: codeready-toolchain/api#492
Jira: https://issues.redhat.com/browse/SANDBOX-1484
Summary by CodeRabbit