-
Notifications
You must be signed in to change notification settings - Fork 37
SANDBOX-1357: update kube & openshift dependencies to 4.19 #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rsoaresd
merged 13 commits into
codeready-toolchain:master
from
rsoaresd:upgrade_4_19_registration_service
Sep 16, 2025
Merged
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
94e0128
SANDBOX-1357: update kube & openshift dependencies to 4.19
3118a9e
update
dbcdf13
try
rsoaresd 1367bab
clean
rsoaresd ef1d5f6
fix
rsoaresd b700531
update golang.org/x/net
rsoaresd d10c64d
go mod tidy
rsoaresd 75c3c3b
Merge branch 'master' into upgrade_4_19_registration_service
rsoaresd 70cec98
clean
rsoaresd c731502
update replace
rsoaresd 724652d
Merge branch 'master' into upgrade_4_19_registration_service
rsoaresd 48279d2
update
rsoaresd 6145c9e
remove replace
rsoaresd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,6 +30,7 @@ linters: | |
| - testifylint | ||
| - unparam | ||
| - zerologlint | ||
| - copyloopvar | ||
| disable: | ||
| - contextcheck | ||
| - noctx | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1 @@ | ||
| ignored-vulnerabilities: | ||
| # Request smuggling due to acceptance of invalid chunked data in net/http | ||
| # Found in Found in: net/http/internal@go1.22.12 | ||
| # Fixed in Fixed in: net/http/internal@go1.23.8 | ||
| - id: GO-2025-3563 | ||
| info: https://pkg.go.dev/vuln/GO-2025-3563 | ||
| silence-until: 2025-09-17 | ||
|
|
||
| # Incorrect Neutralization of Input During Web Page Generation in x/net in golang.org/x/net | ||
| # Found in Found in: golang.org/x/net/html@v0.33.0 | ||
| # Fixed in Fixed in: golang.org/x/net/html@v0.38.0 | ||
| - id: GO-2025-3595 | ||
| info: https://pkg.go.dev/vuln/GO-2025-3595 | ||
| silence-until: 2025-09-17 | ||
|
|
||
| # Inconsistent handling of O_CREATE|O_EXCL on Unix and Windows in os in syscall | ||
| # Found in Found in: os@go1.22.12 | ||
| # Fixed in Fixed in: os@go1.23.10 | ||
| - id: GO-2025-3750 | ||
| info: https://pkg.go.dev/vuln/GO-2025-3750 | ||
| silence-until: 2025-09-17 | ||
|
|
||
| # Sensitive headers not cleared on cross-origin redirect in net/http | ||
| # Found in Found in: net/http@go1.22.12 | ||
| # Fixed in Fixed in: net/http@go1.23.10 | ||
| - id: GO-2025-3751 | ||
| info: https://pkg.go.dev/vuln/GO-2025-3751 | ||
| silence-until: 2025-09-17 | ||
| ignored-vulnerabilities: [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Confirm OpenShift API branch matches the target 4.19 update.
The comment says “release-4.16” while the PR targets 4.19. Ensure this tracks the correct branch for 4.19, or update the comment/dependency accordingly.
🌐 Web query:
💡 Result:
Short answer: use the release-4.19 branch of github.com/openshift/api. OpenShift 4.19 is based on Kubernetes 1.32 (k8s v0.32.x), so match the openshift/api release-4.19 branch with k8s v0.32.x client libraries. [1][2][3]
Sources
Replace the incorrect 'release-4.16' comment and pin openshift/api to release-4.19 (OpenShift 4.19 → Kubernetes 1.32 / k8s v0.32.x).
Change the inline comment and verify the go.mod revision is from the release-4.19 branch (or update the dependency to the release-4.19 commit/tag) and ensure k8s client libraries are v0.32.x.
File: go.mod Lines: 151-154
🤖 Prompt for AI Agents