Skip to content

introduce a simple abstraction for easier handling of finalizers#485

Closed
metlos wants to merge 1 commit intocodeready-toolchain:masterfrom
metlos:finalizer-on-nstemplatetiers
Closed

introduce a simple abstraction for easier handling of finalizers#485
metlos wants to merge 1 commit intocodeready-toolchain:masterfrom
metlos:finalizer-on-nstemplatetiers

Conversation

@metlos
Copy link
Contributor

@metlos metlos commented Jun 12, 2025

This can be used for simplification of the finalizer handling in the controllers.

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.60%. Comparing base (109b36e) to head (ab69e4f).

Files with missing lines Patch % Lines
pkg/finalizers/finalizers.go 70.00% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
- Coverage   78.70%   78.60%   -0.10%     
==========================================
  Files          52       53       +1     
  Lines        2648     2678      +30     
==========================================
+ Hits         2084     2105      +21     
- Misses        502      509       +7     
- Partials       62       64       +2     
Files with missing lines Coverage Δ
pkg/finalizers/finalizers.go 70.00% <70.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@metlos
Copy link
Contributor Author

metlos commented Jun 13, 2025

We will no go ahead with this. It's not bringing enough benefit and doesn't fit all the usecases.

@metlos metlos closed this Jun 13, 2025
@metlos metlos deleted the finalizer-on-nstemplatetiers branch June 13, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant