clean up the spaces after the test so that the ns template tier is deletable#1161
Merged
metlos merged 4 commits intocodeready-toolchain:masterfrom Jun 20, 2025
Merged
Conversation
metlos
force-pushed
the
finalizer-on-nstemplatetiers
branch
from
16d32d1 to
423a509
Compare
…er is deletable" This reverts commit 423a509.
… can wait longer for certain types of objects
|
MatousJobanek
approved these changes
Jun 20, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MatousJobanek, metlos The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
fbm3307
pushed a commit
to fbm3307/toolchain-e2e
that referenced
this pull request
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new finalizer on the NSTemplateTier prevents it from being deleted as long as there are spaces that reference it.
Some tests didn't clean up the spaces properly leaving the NSTemplateTier not deleteable.
Related PRs: