feat: return workato webhook url in the response of /uiconfig #1221
Conversation
WalkthroughAdds Changes
Sequence Diagram(s)sequenceDiagram
participant Test as e2e test (client)
participant Reg as registration-service
participant Config as ToolchainConfig store
rect rgba(150, 200, 255, 0.12)
Test->>Reg: GET /api/v1/uiconfig (signed token)
note right of Reg: reads configuration
Reg->>Config: fetch spec.host.registrationService
Config-->>Reg: returns workatoWebHookURL
Reg-->>Test: 200 OK with { workatoWebHookURL: "<value>", ... }
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (3)
deploy/host-operator/e2e-tests/toolchainconfig.yaml(1 hunks)go.mod(1 hunks)test/e2e/parallel/registration_service_test.go(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-01T09:54:02.406Z
Learnt from: fbm3307
Repo: codeready-toolchain/toolchain-e2e PR: 1175
File: deploy/base1ns-gotemplate/cluster.yaml:69-70
Timestamp: 2025-08-01T09:54:02.406Z
Learning: The codeready-toolchain/toolchain-e2e project is not using the latest version of Kubernetes yet, so deprecated API groups like `ingresses.extensions` may still be functional in their current environment. Consider this when reviewing resource quotas and API usage.
Applied to files:
go.mod
🧬 Code graph analysis (1)
test/e2e/parallel/registration_service_test.go (2)
testsupport/init.go (1)
WaitForDeployments(191-256)testsupport/regsvc.go (1)
NewHTTPRequest(18-22)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: GolangCI Lint
- GitHub Check: Unit Tests
- GitHub Check: Build & push operator bundles for e2e tests
- GitHub Check: Build & push Developer Sandbox UI image for UI e2e tests
🔇 Additional comments (3)
go.mod (1)
4-4: LGTM! Dependency update aligns with new CRD field.The API dependency update is necessary to support the new
workatoWebHookURLfield being added to the ToolchainConfig CRD.deploy/host-operator/e2e-tests/toolchainconfig.yaml (1)
20-20: LGTM! Test configuration for webhook URL.The
workatoWebHookURLconfiguration is correctly placed underspec.host.registrationServiceand uses an appropriate test value for e2e testing.test/e2e/parallel/registration_service_test.go (1)
993-1020: No duplicate test function declarations found — code is correct.Verification confirms only one
TestUIConfigfunction declaration exists in the file (line 993). The AI-generated summary was incorrect; there are no duplicates and no compilation errors from this concern.
alexeykazakov
left a comment
alexeykazakov
left a comment
There was a problem hiding this comment.
Besides the coderebit comment looks good.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, mfrancisc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
test/e2e/parallel/registration_service_test.go (1)
1006-1008: Remove misleading comment.The comment states "we have a user in the system" but no user is actually created or required for this test. This appears to be leftover from copying the test structure from
TestUsernamesabove. Since the/uiconfigendpoint is testing configuration values rather than user-specific data, this comment should be removed or updated to reflect the actual test behavior.Apply this diff to remove the misleading comment:
t.Run("get uiconfig 200 response", func(t *testing.T) { - // given - // we have a user in the system - // when // we call the get uiconfig endpoint to get ui configuration
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
test/e2e/parallel/registration_service_test.go(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
test/e2e/parallel/registration_service_test.go (2)
testsupport/init.go (1)
WaitForDeployments(191-256)testsupport/regsvc.go (1)
NewHTTPRequest(18-22)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build & push Developer Sandbox UI image for UI e2e tests
- GitHub Check: Build & push operator bundles for e2e tests
🔇 Additional comments (2)
test/e2e/parallel/registration_service_test.go (2)
1016-1016: Previous critical issue has been resolved.The type assertion on this line is now correct (asserting to
string). This resolves the critical issue flagged in the previous review where it was incorrectly asserting tomap[string]interface{}.
993-1020: No duplicate test exists — original review comment was based on incorrect information.The verification confirms only one
TestUIConfigfunction declaration exists in the file (at line 993). The AI-generated summary that prompted the review comment was inaccurate. The code requires no changes.Likely an incorrect or invalid review comment.
2 participants
e2e tests for: codeready-toolchain/registration-service#558
Jira: https://issues.redhat.com/browse/SANDBOX-1484
Summary by CodeRabbit
New Features
Dependencies
Tests