-
Notifications
You must be signed in to change notification settings - Fork 78
SANDBOX-1465: update kube & openshift dependencies to 4.20 #1239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rsoaresd
merged 12 commits into
codeready-toolchain:master
from
rsoaresd:upgrade_4_20_dependencies_toolchain-e2e
Jan 8, 2026
+159
−202
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
74b5603
SANDBOX-1357: update kube & openshift dependencies to 4.20
rsoaresd e478e0c
requested changes
rsoaresd b007b29
update
rsoaresd 8645c7e
Merge branch 'master' into upgrade_4_20_dependencies_toolchain-e2e
rsoaresd ac316fc
Merge branch 'master' into upgrade_4_20_dependencies_toolchain-e2e
rsoaresd 2859c7a
Merge branch 'master' into upgrade_4_20_dependencies_toolchain-e2e
rsoaresd b181ace
Merge branch 'master' into upgrade_4_20_dependencies_toolchain-e2e
rsoaresd 474ec1e
Merge branch 'master' into upgrade_4_20_dependencies_toolchain-e2e
rsoaresd b1c17c6
Merge branch 'master' into upgrade_4_20_dependencies_toolchain-e2e
rsoaresd 7ceb791
remove replaces
rsoaresd 0ad6398
update
rsoaresd 20f2577
update
rsoaresd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,55 +1 @@ | ||
| ignored-vulnerabilities: | ||
| # Panic when validating certificates with DSA public keys in crypto/x509 | ||
| # Found in: crypto/[email protected] | ||
| # Fixed in: crypto/[email protected] | ||
| - id: GO-2025-4013 | ||
| info: https://pkg.go.dev/vuln/GO-2025-4013 | ||
| silence-until: 2026-02-05 | ||
| # Lack of limit when parsing cookies can cause memory exhaustion in net/http | ||
| # Found in: net/[email protected] | ||
| # Fixed in: net/[email protected] | ||
| - id: GO-2025-4012 | ||
| info: https://pkg.go.dev/vuln/GO-2025-4012 | ||
| silence-until: 2026-02-05 | ||
| # Parsing DER payload can cause memory exhaustion in encoding/asn1 | ||
| # Found in: encoding/[email protected] | ||
| # Fixed in: encoding/[email protected] | ||
| - id: GO-2025-4011 | ||
| info: https://pkg.go.dev/vuln/GO-2025-4011 | ||
| silence-until: 2026-02-05 | ||
| # Insufficient validation of bracketed IPv6 hostnames in net/url | ||
| # Found in: net/[email protected] | ||
| # Fixed in: net/[email protected] | ||
| - id: GO-2025-4010 | ||
| info: https://pkg.go.dev/vuln/GO-2025-4010 | ||
| silence-until: 2026-02-05 | ||
| # Quadratic complexity when parsing some invalid inputs in encoding/pem | ||
| # Found in: encoding/[email protected] | ||
| # Fixed in: encoding/[email protected] | ||
| - id: GO-2025-4009 | ||
| info: https://pkg.go.dev/vuln/GO-2025-4009 | ||
| silence-until: 2026-02-05 | ||
| # ALPN negotiation error contains attacker controlled information in crypto/tls | ||
| # Found in: crypto/[email protected] | ||
| # Fixed in: crypto/[email protected] | ||
| - id: GO-2025-4008 | ||
| info: https://pkg.go.dev/vuln/GO-2025-4008 | ||
| silence-until: 2026-02-05 | ||
| # Quadratic complexity when checking name constraints in crypto/x509 | ||
| # Found in: crypto/[email protected] | ||
| # Fixed in: crypto/[email protected] | ||
| - id: GO-2025-4007 | ||
| info: https://pkg.go.dev/vuln/GO-2025-4007 | ||
| silence-until: 2026-02-05 | ||
| # Excessive resource consumption when printing error string for host certificate validation in crypto/x509 | ||
| # Found in: crypto/[email protected] | ||
| # Fixed in: crypto/[email protected] | ||
| - id: GO-2025-4155 | ||
| info: https://pkg.go.dev/vuln/GO-2025-4155 | ||
| silence-until: 2026-02-04 | ||
| # Improper application of excluded DNS name constraints when verifying wildcard names in crypto/x509 | ||
| # Found in: crypto/[email protected] | ||
| # Fixed in: crypto/[email protected] | ||
| - id: GO-2025-4175 | ||
| info: https://pkg.go.dev/vuln/GO-2025-4175 | ||
| silence-until: 2026-02-04 | ||
| ignored-vulnerabilities: [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,8 +8,8 @@ ENV GOPATH=/tmp/go \ | |
| PATH=$PATH:$GOPATH/bin \ | ||
| GIT_COMMITTER_NAME="Developer Sandbox" \ | ||
| [email protected] \ | ||
| GOLANG_VERSION=go1.23.12 \ | ||
| GOLANG_SHA256=d3847fef834e9db11bf64e3fb34db9c04db14e068eeb064f49af747010454f90 | ||
| GOLANG_VERSION=go1.24.11 \ | ||
| GOLANG_SHA256=bceca00afaac856bc48b4cc33db7cd9eb383c81811379faed3bdbc80edb0af65 | ||
|
|
||
| # Install additional tools | ||
| # gettext for envsubst | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: codeready-toolchain/toolchain-e2e
Length of output: 59
🏁 Script executed:
Repository: codeready-toolchain/toolchain-e2e
Length of output: 1559
🏁 Script executed:
Repository: codeready-toolchain/toolchain-e2e
Length of output: 723
🏁 Script executed:
Repository: codeready-toolchain/toolchain-e2e
Length of output: 142
🏁 Script executed:
Repository: codeready-toolchain/toolchain-e2e
Length of output: 59
🏁 Script executed:
Repository: codeready-toolchain/toolchain-e2e
Length of output: 216
🏁 Script executed:
Repository: codeready-toolchain/toolchain-e2e
Length of output: 435
🏁 Script executed:
Repository: codeready-toolchain/toolchain-e2e
Length of output: 109
🏁 Script executed:
Repository: codeready-toolchain/toolchain-e2e
Length of output: 1148
🏁 Script executed:
Repository: codeready-toolchain/toolchain-e2e
Length of output: 1933
🏁 Script executed:
Repository: codeready-toolchain/toolchain-e2e
Length of output: 944
🏁 Script executed:
Repository: codeready-toolchain/toolchain-e2e
Length of output: 185
🏁 Script executed:
Repository: codeready-toolchain/toolchain-e2e
Length of output: 59
🏁 Script executed:
Repository: codeready-toolchain/toolchain-e2e
Length of output: 1928
🏁 Script executed:
# Check go.mk for build/test configuration cat make/go.mkRepository: codeready-toolchain/toolchain-e2e
Length of output: 1019
🏁 Script executed:
Repository: codeready-toolchain/toolchain-e2e
Length of output: 4505
🏁 Script executed:
Repository: codeready-toolchain/toolchain-e2e
Length of output: 474
🏁 Script executed:
Repository: codeready-toolchain/toolchain-e2e
Length of output: 330
🏁 Script executed:
Repository: codeready-toolchain/toolchain-e2e
Length of output: 484
🏁 Script executed:
Repository: codeready-toolchain/toolchain-e2e
Length of output: 127
🏁 Script executed:
Repository: codeready-toolchain/toolchain-e2e
Length of output: 127
🏁 Script executed:
Repository: codeready-toolchain/toolchain-e2e
Length of output: 102
🌐 Web query:
Go 1.24 release notes breaking changes goroutine semantics memory💡 Result:
Short summary of Go 1.24 items related to breaking changes, goroutine semantics, and memory
Official release summary: Go 1.24 focuses on runtime/GC and allocation improvements (new map implementation, faster small-object allocation, runtime mutex), and small language/tool changes — full notes at the Go blog and release notes. [1][2]
Breaking/compatibility items to watch:
Memory/GC/runtime effects:
References
[1] Go 1.24 is released! (Go blog).
[2] Go 1.24 Release Notes (tip.golang.org/doc/go1.24).
[3] Community reports / discussion of concurrent test flakiness after 1.24 (examples on Reddit / issues).
🌐 Web query:
Kubernetes k8s.io v0.33.4 Go 1.24 compatibility support💡 Result:
Short answer: Yes — the k8s.io v0.33.x line corresponds to Kubernetes v1.33, which was moved to Go 1.24; client libraries in the v0.33.x series are compatible with Go 1.24. (pkg.go.dev)
Notes:
Citations:
Monitor for test flakiness related to Go 1.24 runtime scheduling changes.
The upgrade from Go 1.23.0 to 1.24.4 is a minor version bump. Verification confirms:
make test(runs testsupport and setup test packages)However, Go 1.24 introduced runtime scheduling and GC optimizations that can shift execution ordering. This may expose existing concurrency bugs or cause test flakiness in code that relies on specific scheduling behavior. Review test results for any intermittent failures, particularly in concurrent workloads, and use the race detector (
go test -race) if concurrency issues emerge.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using toolchain go1.24.11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rsoaresd, thank you for the clarification! I see the toolchain is indeed set to
go1.24.11(a patch release) while thegodirective is1.24.4. The advice about monitoring for potential test flakiness still applies across the Go 1.24.x line due to runtime changes, but the patch release may include additional fixes. The existing CI test suite should help catch any issues.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I try to point to
go 1.24.0, it automatilly changes togo 1.24.4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rsoaresd, that's correct! This is expected behavior from the Go toolchain. When you run
go mod tidyor similar commands, Go automatically updates thegodirective to the minimum version required by your dependencies. In this case, one or more of your dependencies (likely the k8s.io v0.33.4 modules or controller-runtime v0.21.0) requires Go 1.24.4 as the minimum version, so Go enforces that in thegodirective.The setup you have is correct:
go 1.24.4— minimum Go version required by the module and its dependenciestoolchain go1.24.11— the specific Go toolchain version used for buildsThis ensures compatibility while using the latest patch release for builds. Thank you for the clarification!