Skip to content

Conversation

@samumantha
Copy link
Member

@samumantha samumantha commented Jul 9, 2025

This is a PR to learn something :)

I reused the build workflow and adapted for zola check, now I am wondering if it will work like this.

Questions:

  • How can I test it? When I try to run it from the actions menu, it is skipped..
  • Does it make sense to have the check separate from zola build? I thought yes, to have the errors separate and easier find whats wrong, but maybe not?
  • Should it be run on push and pull request?
  • I probably have forgotten something essential what this workflow should also do, please let me know and I can continue :)

@github-actions
Copy link

github-actions bot commented Jul 9, 2025

Once the build has completed, you can preview your PR at this URL: https://coderefinery.org/previews/PR938/

@samumantha samumantha marked this pull request as ready for review July 9, 2025 12:35
@samumantha samumantha requested review from bast and rkdarst July 9, 2025 12:41
@bast
Copy link
Member

bast commented Jul 9, 2025

I would run it in the same workflow that also builds the site. This is a bit "greener" consumes less CPU/network and also answers the questions on what events to run it (always).

@samumantha
Copy link
Member Author

Makes sense, moved to the build workflow file

@bast bast merged commit 37cf7e0 into main Jul 9, 2025
3 checks passed
@bast bast deleted the swi-links branch July 9, 2025 13:49
@samumantha samumantha mentioned this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants