Skip to content

Conversation

@YuTian8328
Copy link
Contributor

  • Add a new dataset from year 2024 with temperatures and precipitations
  • Update the iterative solution with the new dataset

@bast
Copy link
Member

bast commented Sep 24, 2025

I am reviewing ...

@bast bast self-assigned this Sep 24, 2025
@bast
Copy link
Member

bast commented Oct 7, 2025

Few things I will add or consider adding before merging:

  • instead of reset_index and working with "measurement index", I might change the data to contain proper dates so that we can use panda's datetime (easier and more realistic)
  • instead of averaging the precipitation it is more meaningful to compute the total precipitation per month
  • consider switching to using explicit interface in matplotlib to be closer to the Python for SciComp material
  • the step from side effects towards more pure functions can be made a bit clearer
  • at some point when switching to script/testing/cli we don't want to "show" anymore
  • I would like to let user specify the output path in the CLI solution (allows to separate input data from output data and connects better to workflows)
  • auto-format code
  • update text in the md file
  • re-introduce line emphasis in code examples
  • update the exercise repo after these changes
  • add Yu as co-author

@bast bast merged commit 0ea0b4f into main Oct 12, 2025
4 checks passed
@bast bast deleted the yu/update-example-script branch October 12, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants