Open
Conversation
✅ Deploy Preview for stellar-platypus-904acb ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Mariusz-web
requested review from
KonTra7cf,
T0ffik,
Veryyapeee and
maciejopalinski
Veryyapeee
requested changes
May 22, 2022
Veryyapeee
left a comment
Veryyapeee
left a comment
There was a problem hiding this comment.
Also remove console.logs, or add TODO comments
| <BrowserRouter> | ||
| <Routes> | ||
| <Route | ||
| {/* <Route |
There was a problem hiding this comment.
why is it commented? Also the login/register screen shouldn't have header
|
|
||
| export const Register = () => { | ||
| return <div>Register</div>; | ||
| const [firstName, setFirstName] = useState(''); |
There was a problem hiding this comment.
That patters is realllyyy bad, for many many reasons
The obvious ones (except for readability etc.) are:
- State shouldn't be decentralized like that
- Each type in each input would case rerender
- Creating validation for that would be now just pain in the ass
Doing that using react-hook-form would take probably like 5 minutes, especially that we have code for forms like that in previous project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.