-
Notifications
You must be signed in to change notification settings - Fork 2
feat: project setup #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.github/workflows/main.yml
Outdated
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [22.x] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to be more permissive with version, following what rhea supports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright, i will put the same versions as in rhea workflow https://github.com/amqp/rhea/blob/main/.github/workflows/node.js.yml#L18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure this file is executed by vite?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added the file to the list of setup files and set sequence setup to list, so we can decide the order to run the files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure this file is executed by vite?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added the file to the list of setup files and set sequence setup to list, so we can decide the order to run the files
test/e2e/management.test.ts
Outdated
| management.close() | ||
| }) | ||
|
|
||
| test("create a queue through the management", async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set as skip so we can merge without broken test
test/tsconfig.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure it's necessary this file? with the tsconfi.json that include include": ["src/**/*", "test/**/*", "vitest.config.mts"], I don't think it's necessary
Add basic project setup using node and esm, replacing mocha with vitest for esm compatibility