Skip to content

Conversation

@l4mby
Copy link
Contributor

@l4mby l4mby commented May 15, 2025

Add basic project setup using node and esm, replacing mocha with vitest for esm compatibility

@l4mby l4mby requested a review from apietroni51 May 15, 2025 06:55
@l4mby l4mby self-assigned this May 15, 2025
@l4mby l4mby linked an issue May 15, 2025 that may be closed by this pull request

strategy:
matrix:
node-version: [22.x]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to be more permissive with version, following what rhea supports

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, i will put the same versions as in rhea workflow https://github.com/amqp/rhea/blob/main/.github/workflows/node.js.yml#L18

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure this file is executed by vite?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the file to the list of setup files and set sequence setup to list, so we can decide the order to run the files

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure this file is executed by vite?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the file to the list of setup files and set sequence setup to list, so we can decide the order to run the files

management.close()
})

test("create a queue through the management", async () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set as skip so we can merge without broken test

@l4mby l4mby requested a review from gpad May 19, 2025 08:25
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure it's necessary this file? with the tsconfi.json that include include": ["src/**/*", "test/**/*", "vitest.config.mts"], I don't think it's necessary

@l4mby l4mby requested a review from gpad May 19, 2025 14:27
@l4mby l4mby merged commit f9dcff2 into main May 20, 2025
5 checks passed
@albertobarrila albertobarrila deleted the 1-walking-skeleton-setup branch July 4, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Walking skeleton setup

3 participants