Skip to content

Conversation

@apietroni51
Copy link
Contributor

  • Added TLS params for the environment definition
  • Added certificate generation with a Makefile for tests

@apietroni51 apietroni51 requested a review from l4mby September 10, 2025 14:20
@apietroni51 apietroni51 linked an issue Sep 10, 2025 that may be closed by this pull request
@apietroni51 apietroni51 marked this pull request as ready for review September 15, 2025 12:36
@gpad gpad requested a review from Copilot September 15, 2025 13:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds TLS/SSL connection support to the RabbitMQ client library, allowing library users to connect to RabbitMQ instances over secure TLS connections.

  • Added TLS configuration parameters to the environment definition including certificate, key, and CA options
  • Implemented TLS parameter processing in the connection building logic
  • Set up certificate generation infrastructure and testing for TLS connections

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/environment.ts Added TlsParams type definition with certificate configuration options
src/rhea_wrapper.ts Implemented buildTlsParams function and integrated TLS parameters into connection options
test/e2e/tls_connection.test.ts Added end-to-end test for TLS connection functionality
conf/rabbitmq.conf Configured RabbitMQ server with SSL listener and certificate settings
docker-compose.yml Added TLS port mapping and certificate volume mount
Makefile Added certificate generation commands for testing
.github/workflows/main.yml Enabled certificate generation and TLS testing in CI pipeline
cspell.json Added TLS-related terms to spelling dictionary

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@apietroni51 apietroni51 force-pushed the 68-as-a-library-user-i-want-to-connect-to-rabbit-through-tlsssl branch from d9b8648 to 6fb02e0 Compare September 15, 2025 13:31
@apietroni51 apietroni51 merged commit ef9370c into main Sep 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

As a library user I want to connect to rabbit through TLS/SSL

3 participants