-
Notifications
You must be signed in to change notification settings - Fork 11
230 change stream options when already created #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Gsantomaggio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To use the deduplication, the client needs to expose an API to pass the publishingid; otherwise it does not make sense :)
See for example the Go-client:
https://github.com/rabbitmq/rabbitmq-stream-go-client/blob/main/examples/deduplication/deduplication.go#L66-L84
where the user must provide the id for each message to avoid duplications
or the .NET client where with the message you can pass the id the API
https://github.com/rabbitmq/rabbitmq-stream-dotnet-client/blob/main/RabbitMQ.Stream.Client/Reliable/DeduplicatingProducer.cs#L71
Ok, but passing |
It is mandatory else the deduplication won't work. In this implementation, deduplication works like the standard producer. |
Gsantomaggio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
In this PR I removed the
bootparameter that was used to activate the deduplication. From now, to activate the deduplication you just need to define apublisherRefvalue.I also fixed a race condition when sending multiple messages concurrently with deduplication actived.