fix(client): capture console values at log time#1295
Open
Sembauke wants to merge 1 commit intocodesandbox:mainfrom
Open
fix(client): capture console values at log time#1295Sembauke wants to merge 1 commit intocodesandbox:mainfrom
Sembauke wants to merge 1 commit intocodesandbox:mainfrom
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
@Sembauke is attempting to deploy a commit to the CodeSandbox Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes console payload mutation in Sandpack previews by capturing log data at call time.
When a mutable value is logged and then mutated immediately after, the first log could incorrectly show the later mutated value. This happened because the previous hook path relied on delayed parsing.
This PR updates the inject script to:
Tests
Added
sandpack-client/src/inject-scripts/consoleHook.test.tswith regressions for:Verification
corepack yarn workspace @codesandbox/sandpack-client test src/inject-scripts/consoleHook.test.tscorepack yarn workspace @codesandbox/sandpack-client buildCloses #1294