Skip to content

chore: prework for npm publish #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mkramb wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

chore: prework for npm publish #134

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
33c8659
chore: prework for npm publish
mkramb Oct 4, 2018
5ecce49
fix
mkramb Oct 4, 2018
895ae6f
Merge branch 'master' into chore/prework-for-npm-publish
ryanjwilke Oct 4, 2018
61345a9
another fix
mkramb Oct 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
*
!assets/stylesheets/**/*
!assets/images/**/*
!assets/icons/**/*
5 changes: 5 additions & 0 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ namespace :shipyard do
end
end

desc 'Publish project to npm as scoped package @codeship/shipyard'
task :console do
sh 'npm publish --access public'
Copy link

@scherler scherler Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the files builded by then (e.g. sass 2 css)?

Copy link
Contributor

@ryanjwilke ryanjwilke Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They can be. The sass files will always be ready to go, but the css would need to be compiled first, yes.

Copy link
Contributor

@ryanjwilke ryanjwilke Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear though, there's no requirement that the CSS is packaged as the best way to consume all of this will be through the sass files anyways.

Copy link
Author

@mkramb mkramb Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start with sass. For some playground or prototyping it would be useful to have compiled versions, but we don't have a use-case for that ATM.

Copy link

@scherler scherler Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo that needs to be the last part of the rakefile.

Copy link
Author

@mkramb mkramb Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

end

desc 'Compiles Shipyard and custom icons into an external svg definitions file.'
task :icons, [:icon_directory, :output_directory] do |t, args|
args.with_defaults(:icon_directory => '/app/assets/icons/', :output_directory => '/public/assets/')
Expand Down