Fix quantity field encoding/decoding and add test suite #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
quantityPb.amountordeprecatedQuantityfields (protobuf format from API)Item._encode()to properly encode quantity asquantityPb.amountper the ListItem protobuf schemaProblem
The quantity field was broken in two ways:
quantityPb.amountordeprecatedQuantity, but the constructor only looked atquantity_encode()tried to set aquantityfield that doesn't exist in the protobuf schema, causing the error:.pcov.proto.ListItem#quantity is not a fieldSolution
quantityPb?.amount ?? deprecatedQuantity ?? quantity_encode()now writes:quantityPb: { amount: String(quantity) }Test Coverage
Added 22 integration tests covering:
Run tests with:
Test plan
🤖 Generated with Claude Code