Skip to content

Conversation

@Apollon77
Copy link
Collaborator

@Apollon77 Apollon77 commented Jan 6, 2025

This PR includes:

  • adding more guards to ensure we only throw or reject once in set()
  • Make sure "set()" throws in timeout cases also to prevent "get via set" to return undefined in an unexpected way
  • moves a set-in-progress guard to the right place
  • adds catches for "get/refresh data on connect" to not crash uncatcheable

... because it only matters if we want to really process a set if tthere is another one somehow "still in progress". Makes no sense to check this before the set is queued
@coveralls
Copy link

coveralls commented Jan 6, 2025

Coverage Status

coverage: 58.291% (-0.6%) from 58.841%
when pulling 960babe on set-fixes
into 4f488ed on master.

@Apollon77 Apollon77 merged commit 3b29626 into master Jan 6, 2025
24 checks passed
@Apollon77 Apollon77 deleted the set-fixes branch January 6, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants