Skip to content

Add MSAVI index to backend #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wherop merged 28 commits into from
Dec 3, 2024
Merged

Add MSAVI index to backend #29

wherop merged 28 commits into from
Dec 3, 2024

Conversation

@wherop
Copy link
Collaborator

@wherop wherop commented Nov 25, 2024 •
edited
Loading

tomADC443 and others added 25 commits November 18, 2024 15:05
@tomADC443 @wherop
feat: check that time range is valid for S2 harmonized collection
8e9ef5e
@tomADC443 @wherop
feat: add preprocessing step to remove unnecessary bands from images
78d8aee
@tomADC443 @wherop
refactor: Aggregation and Filler DataFrame operations into two separa…
3e35820 
…te functions
@tomADC443 @wherop
refactor: temporal utility functions (cleaner, more readable)
d06b41f
@tomADC443 @wherop
fix: different timezones (now always utc)
128b9c4
@tomADC443 @wherop
feat: introduce static cache file
326e70a
@wherop
refactor: delete emply file
43f992c
@wherop
refactor: delete emply file
a2bc44f
@wherop
feat: refactor 'ndvi_router' to 'sat_index_router'; add MSAVI route t…
df6cc26 
…o sat_index_router
@wherop
Merge branch 'main' into feature/msavi-endpoint
084a689
@wherop
refactor: rename image preprocessing file
109c80e
@wherop
refactor: rename gee/ndvi.py to gee/sat_index_info.py
331fdea
@wherop
feat: add function to change index formula
437f864
@wherop
feat: pass index_type from router to GEE
60295bb
@wherop
Merge branch 'main' into feature/msavi-endpoint
05a751b
@wherop
refactor: add '__init__.py' to all python package directories
b8828d4
@wherop
fix: update fastapi dependency reference to 'fastapi[standard]'
b517f73
@wherop
fix: correct constants import error
d9c1ec3
@wherop
style: update route labels to be more descriptive
128650b
@wherop
feat: add index type to response meta; correct unit for MSAVI meta
d98b02e
@wherop
feat&docs: add comments and print statements to index service
86e72fe
@wherop
refactor: move NDVI cache to cache directory
a5edee1
@wherop
feat: create MSAVI cache
b9a52b1
@wherop
feat: add a rudamentary caching script (WIP)
dcf318d
@wherop
feat: integrate MSAVI cache
69767bc
@wherop wherop changed the title Feature/msavi endpoint Add MSAVI index to backend Nov 25, 2024
@wherop wherop requested a review from tomADC443 December 2, 2024 23:53
tomADC443
tomADC443 reviewed Dec 3, 2024
View reviewed changes
backend/src/routes/sat_index_router.py
...,
description="Method of aggregating available data into a single datapoint to represent the selected time interval e.g. mean average",
),
):
Copy link
Collaborator

@tomADC443 tomADC443 Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the long run we might wanna put the schema for input validation into a seperate file which would probably lead to less code and more reusability :)

Copy link
Collaborator Author

@wherop wherop Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I encountered many things like this that I want to change. I decided not to include them in the scope of this branch.

@tomADC443
Copy link
Collaborator

tomADC443 commented Dec 3, 2024

Very nice generalization of the existing architecture to work with all indexes 👍

@tomADC443
Copy link
Collaborator

tomADC443 commented Dec 3, 2024

i liked how you made the cache 'writeable' and thanks a lot for all the refactoring and clean up!

@wherop wherop merged commit 040a714 into main Dec 3, 2024
1 check passed
@wherop wherop deleted the feature/msavi-endpoint branch December 3, 2024 15:12
@wherop wherop restored the feature/msavi-endpoint branch December 4, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomADC443 tomADC443 tomADC443 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Requesting same end date as current cache end date crashes server.

3 participants

@wherop @tomADC443