testing if the api is working and add the test to the deployment script #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rl from the env file
DrAdamRoe
approved these changes
Nov 26, 2024
Contributor
DrAdamRoe
left a comment
DrAdamRoe
left a comment
There was a problem hiding this comment.
Thanks for the commit, this look good. I am concerned that the timeout to wait for the application to start could put us in an infinite loop though. I would expect that if the docker container starts but the application itself never starts, this request retried indefinitely. Is that what you think would happen? And could we find another solution if that is the case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, I added a new test case to verify if the API is working with just the main base URL. I also updated the deployment script to re-run the tests and modified
tests-main.yamlto run the tests in the Docker container.After merging this pull request, you will need to add
API_BASE_URLto your.envfile in your local development environment to run pytest.