-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fixed incorrect identify of the current block if a nested editor is used in it #2961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VolgaIgor
wants to merge
4
commits into
codex-team:next
Choose a base branch
from
VolgaIgor:fix-nested-focus
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+85
−7
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8a6da99
Fixed incorrect identify of the current block if a nested editor is u…
VolgaIgor 2987fcc
Added test to check the current block id in the nested editor
VolgaIgor 95f2def
Merge branch 'next' into fix-nested-focus
VolgaIgor 4423629
Instead of a new class for NestedEditor an existing was used
VolgaIgor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have the
getBlock()method ofBlockManagerwhich seems to be used for the case "find block by element".Maybe we can:
/utils/blocksThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not the right solution to use this method. Because for now
getBlock()method is used to get a block only by its holder element, without searching by children elements. So, searching for the parent editor block by the nested editor element will greatly change the logic of this method. And as I can tell from a quick look at the code, it will break some modules.A better solution may be to combine this method with methods
getBlockByChildNode()and/orsetCurrentBlockByChildNode(). However, this also cannot be done clearly, because it is also will break some modules. For example, as far as I understand, in this case the paste module will start pasting data into all editors in the chain, rather than a instance in focus: paste.ts. Also, selection processing methods wait to receive blocks of the editor in which the selection occurs, and not of a nested one.So, to combine this method with others in the current implementation, it will be necessary to add a flag option that would prohibit searching in nested editors, because many methods don't need it. Therefore, in my commit I did not combine them for now, and made a separate method that is used only in places where it is necessary.