fix(payments): Rewrite composePayment with graphql #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neSpecc
reviewed
Aug 9, 2025
src/api/billing/index.ts
Outdated
Comment on lines
56
to
60
| const { data, errors } = await api.call(QUERY_COMPOSE_PAYMENT, { | ||
| input: { workspaceId, tariffPlanId, shouldSaveCard }, | ||
| }); | ||
|
|
||
| return data.composePayment as BeforePaymentPayload; |
Member
There was a problem hiding this comment.
GraphQL can return data correctly along with errors.
Its better to return both data and errors in this method. And handle them in ancestor-level. See FETCH_CURRENT_USER and FETCH_INITIAL_DATA as examples
| const key = 'errors.' + (e as Error).message; | ||
| const message = this.$te(key) ? this.$t(key) as string : this.$t('billing.notifications.error'); | ||
| console.log('this.$te(key)', key, this.$te(key)); |
Member
There was a problem hiding this comment.
Suggested change
| console.log('this.$te(key)', key, this.$te(key)); |
| }); | ||
| } catch (e) { | ||
| const key = 'errors.' + (e as Error).message; | ||
| const message = this.$te(key) ? this.$t(key) as string : this.$t('billing.notifications.error'); |
Member
There was a problem hiding this comment.
I believe authorization errors should be handled in a central place.
neSpecc
approved these changes
Aug 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps fix probrem when user tries to pay but he is not authenticated
works with codex-team/hawk.api.nodejs#520