Feat(grouper): manual event grouping #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* deps(): add babel dependencies * imp(javascript): improve source-map parsing
slaveeks
reviewed
Mar 14, 2025
workers/grouper/src/index.ts
Outdated
| * If there is no first event for pattern, then just save event as first | ||
| */ | ||
| if (matchingPattern !== null) { | ||
| const originalEvent = await this.eventsDb.getConnection() |
neSpecc
reviewed
Mar 16, 2025
neSpecc
approved these changes
Mar 16, 2025
neSpecc
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Additional
Remove cache key on event saving to database
Note
this is part of global work on Event Manual Grouping feature, check related prs
GARAGE: codex-team/hawk.garage#677
API: codex-team/hawk.api.nodejs#478
TYPES: codex-team/hawk.types#46- already merged