fix(releases): cover case with empty map body #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neSpecc
approved these changes
Apr 10, 2025
e11sy
added a commit
that referenced
this pull request
Apr 24, 2025
* fix(releases): cover case with empty map body (#397) * imp(email): link to billing (#398) * imp(email): link to billing * chore(email): update patterns * imp(paymaster): add paid until field for workspace (#400) * feat(paymaster): support paid until workspace field * chore(paymaster): update types and test * chore(): lint fix * chore(): lint fix * imp(CI): update ubuntu version * test(paymaster): add new testcase * chore(paymaster): lint fix --------- Co-authored-by: e11sy <130844513+e11sy@users.noreply.github.com>
e11sy
added a commit
that referenced
this pull request
Apr 30, 2025
* fix(releases): cover case with empty map body (#397) * imp(email): link to billing (#398) * imp(email): link to billing * chore(email): update patterns * imp(paymaster): add paid until field for workspace (#400) * feat(paymaster): support paid until workspace field * chore(paymaster): update types and test * chore(): lint fix * chore(): lint fix * imp(CI): update ubuntu version * test(paymaster): add new testcase * chore(paymaster): lint fix * feat(sentry): parse release from event contexts (#401) * feat(sentry): parse release from event contexts * imp(sentry): add task to js worker if release passed * chore(sentry): lint fix * chore(sentry): remove an outdated todo --------- Co-authored-by: e11sy <130844513+e11sy@users.noreply.github.com>
e11sy
added a commit
that referenced
this pull request
May 2, 2025
* fix(releases): cover case with empty map body (#397) * imp(email): link to billing (#398) * imp(email): link to billing * chore(email): update patterns * imp(paymaster): add paid until field for workspace (#400) * feat(paymaster): support paid until workspace field * chore(paymaster): update types and test * chore(): lint fix * chore(): lint fix * imp(CI): update ubuntu version * test(paymaster): add new testcase * chore(paymaster): lint fix * feat(sentry): parse release from event contexts (#401) * feat(sentry): parse release from event contexts * imp(sentry): add task to js worker if release passed * chore(sentry): lint fix * chore(sentry): remove an outdated todo * fix(grouper): get matching pattern fix (#404) --------- Co-authored-by: e11sy <130844513+e11sy@users.noreply.github.com>
neSpecc
added a commit
that referenced
this pull request
May 5, 2025
* fix(releases): cover case with empty map body (#397) * imp(email): link to billing (#398) * imp(email): link to billing * chore(email): update patterns * imp(paymaster): add paid until field for workspace (#400) * feat(paymaster): support paid until workspace field * chore(paymaster): update types and test * chore(): lint fix * chore(): lint fix * imp(CI): update ubuntu version * test(paymaster): add new testcase * chore(paymaster): lint fix * feat(sentry): parse release from event contexts (#401) * feat(sentry): parse release from event contexts * imp(sentry): add task to js worker if release passed * chore(sentry): lint fix * chore(sentry): remove an outdated todo * fix(grouper): get matching pattern fix (#404) * chore(sentry): rm breadcrumbs addon (#406) --------- Co-authored-by: e11sy <130844513+e11sy@users.noreply.github.com> Co-authored-by: Peter <specc.dev@gmail.com>
slaveeks
added a commit
that referenced
this pull request
May 17, 2025
* fix(releases): cover case with empty map body (#397) * imp(email): link to billing (#398) * imp(email): link to billing * chore(email): update patterns * imp(paymaster): add paid until field for workspace (#400) * feat(paymaster): support paid until workspace field * chore(paymaster): update types and test * chore(): lint fix * chore(): lint fix * imp(CI): update ubuntu version * test(paymaster): add new testcase * chore(paymaster): lint fix * feat(sentry): parse release from event contexts (#401) * feat(sentry): parse release from event contexts * imp(sentry): add task to js worker if release passed * chore(sentry): lint fix * chore(sentry): remove an outdated todo * fix(grouper): get matching pattern fix (#404) * chore(sentry): rm breadcrumbs addon (#406) * added new diff logic (#403) * new diff stash * save delta * rm redundant code * Update index.ts * rm old diff * feat: separate original and repetition in encode and decode methods * fixed libs, save stringified json * rem payload * returned repetition payload * removed payload from repetition * fixed some test, added tests for diff * fix types * yarn * rm test from utils * yarn fix * lnt fixes * rm log * rm log * improved doc * rm redundant dep * added jsdoc return type --------- Co-authored-by: Peter Savchenko <specc.dev@gmail.com> --------- Co-authored-by: e11sy <130844513+e11sy@users.noreply.github.com> Co-authored-by: Peter <specc.dev@gmail.com> Co-authored-by: Vyacheslav Chernyshev <81693471+slaveeks@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try-catch does not work if we catching sync error, that is inside of unresolved promise, that's why we were getting error from
saveFilemethod, however it is inside of try-catch.Changes
mapBodyStringleaded to error inconst readable = Readable.from([ file.content ]);