Skip to content
Merged

v0.12.0 #1707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
840 commits
Select commit Hold shift + click to select a range
c1d32eb
fixed comment undelete tests (undelete can now respond with HTML)
Oaphi Jul 8, 2025
bab510a
fixed comment delete tests (delete can now respond with HTML
Oaphi Jul 8, 2025
c100b19
reducing comments controller size: internationalized thread_unrestric…
Oaphi Jul 8, 2025
07ad4e7
slightly simplified CommentsController#thread_followers respond_to (s…
Oaphi Jul 8, 2025
8b273dc
mount coverage directory in dev mode only
Oaphi Jul 9, 2025
aca3cff
fixed default sort param for user searches
Oaphi Jul 10, 2025
35fced2
Merge pull request #1675 from codidact/0valt/1674/user-sorting
Oaphi Jul 10, 2025
c0722fc
switched Style/HashSyntax to ruby19_no_mixed_keys & forbade the short…
Oaphi Jul 10, 2025
f0c1bec
abstracted rate limit checks in CommentsController into the check_cre…
Oaphi Jul 10, 2025
e267c33
Merge pull request #1676 from codidact/0valt/1653/hash-style
ArtOfCode- Jul 10, 2025
548a9ad
Apparently that's changed
ArtOfCode- Jul 11, 2025
26e791b
oops, fixed the wrong lack of focus
Oaphi Jul 11, 2025
4dcaf45
new comment thread button should autofocus the body too
Oaphi Jul 11, 2025
1afe2b3
Merge pull request #1647 from codidact/0valt/1579/comments
ArtOfCode- Jul 11, 2025
7faaf4d
Merge pull request #1669 from codidact/trichoplax/improve-system-test…
ArtOfCode- Jul 11, 2025
42477d4
Merge branch 'develop' into art/self-serve-deletion
Oaphi Jul 11, 2025
f8a0d2e
added try_do_delete_user helper for registrations controller test
Oaphi Jul 11, 2025
6d0b712
added en.users locale strings
Oaphi Jul 11, 2025
b04e1d7
connected user error locale strings to do_delete & its tests
Oaphi Jul 11, 2025
b7fbb70
merged mod & admin self-delete tests
Oaphi Jul 11, 2025
f2dd191
minor cleanup of registrations controller test
Oaphi Jul 11, 2025
c037fff
added try_enter_sudo helper for sudo controller test
Oaphi Jul 11, 2025
42a7b9c
Merge pull request #1678 from codidact/0valt/1668/suggestions
ArtOfCode- Jul 11, 2025
b3be377
Merge pull request #1668 from codidact/art/self-serve-deletion
ArtOfCode- Jul 11, 2025
08cf18f
added storage directory to gitignore to prevent accidental commits of…
Oaphi May 8, 2025
89c0526
added YARD for SearchHelper#search_posts (prevents needing to solve a…
Oaphi Jul 11, 2025
57cd00d
made SearchHelper#accessible_categories_for a class method on Categor…
Oaphi Jul 11, 2025
be1887c
made SearchHelper#accessible_posts_for a class method on Post [access…
Oaphi Jul 11, 2025
8e21b73
moved mod_or_admin? around to avoid having to solve yet another nasty…
Oaphi Jul 11, 2025
24b41b3
accidentally committed Gemfile.lock update (one less merge conflict t…
Oaphi Jul 11, 2025
aa673e4
moving YARD SearchHelper#qualifiers_to_sql from develop (avoiding the…
Oaphi Jul 11, 2025
d3996ba
Merge branch 'develop' into 0valt/1509/search_tests
Oaphi Jul 11, 2025
3b07e00
syncing with develop: User#mod_or_admin? is now User#at_least_moderator?
Oaphi Jul 11, 2025
9e834a9
fixed /usr/local/lib/node_modules not being copied over correctly
Oaphi Jul 12, 2025
798664b
switched to symlinks for several of the Node.js related deps (NPM has…
Oaphi Jul 12, 2025
9a28423
Merge pull request #1679 from codidact/0valt/docker
ArtOfCode- Jul 12, 2025
4e9bf06
Merge branch 'develop' into 0valt/1509/search_tests
Oaphi Jul 12, 2025
1270525
let's setup Rubcop CI while we are at it
Oaphi Jul 12, 2025
ad961f8
uhm, do we really need rubocop-rake in GH Actions?
Oaphi Jul 12, 2025
212ac9d
let's not shout, shall we (Rubocop GH Actions setup)?
Oaphi Jul 12, 2025
d9b7836
installing rubocop-rake directly won't hurt
Oaphi Jul 12, 2025
299bc09
apparently, excluding vendor directory is a must for GitHub Actions
Oaphi Jul 12, 2025
6bbfe2b
let's see if Ruby 3.1 testing works
Oaphi Jul 12, 2025
11d998e
let's make RAILS_ENV a workflow-level var
Oaphi Jul 12, 2025
bb17e1c
now let's add MYSQL to the testing action
Oaphi Jul 12, 2025
f7ee020
ports is an array, duh
Oaphi Jul 12, 2025
92a7fe2
welp, there's no way to set service container entrypoint options, let…
Oaphi Jul 12, 2025
4e3f19b
now add Rails for our testing workflow, won't work without it
Oaphi Jul 12, 2025
bb45351
expose Redis service container port 6379
Oaphi Jul 12, 2025
f95e58b
add Ruby 3.2 testing via GH Actions matrix
Oaphi Jul 12, 2025
02b634d
testing system tests & screenshots
Oaphi Jul 12, 2025
c8cf464
let's see if setup-firefox is any good
Oaphi Jul 13, 2025
772d268
minor testing workflow updates & temp check for where the heck are sc…
Oaphi Jul 13, 2025
2cae369
I hope this is the correct path for screenshot artifacts
Oaphi Jul 13, 2025
3bc884c
final touch for system tests: remove the dummy screenshot test case
Oaphi Jul 13, 2025
dce725f
renamed admin_only category fixture to disambiguate from high_trust
Oaphi Jul 13, 2025
666702b
no, search_posts does not return an ActiveRecord::Relation, but a 2-t…
Oaphi Jul 13, 2025
c2613d7
simplified search_posts helper YARD
Oaphi Jul 13, 2025
1fbd9be
made search_string an explicit parameter of search_posts (so as it ca…
Oaphi Jul 13, 2025
03d2865
switched search_posts & params_to_qualifiers to accept params directly
Oaphi Jul 13, 2025
6c15022
added test for checking that search_posts never returns posts from ca…
Oaphi Jul 13, 2025
e4a6fc6
added missing staff user community user fixture
Oaphi Jul 13, 2025
5eb01f3
added User#can_see_category? access control method
Oaphi Jul 13, 2025
a10f0da
restored User#trust_level to prevent errors on users with no communit…
Oaphi Jul 13, 2025
0f5f17f
made User#can_see_category? more robust
Oaphi Jul 13, 2025
47b9431
added Category#public? access control method
Oaphi Jul 13, 2025
0d5a104
made CategoriesController#verify_view_access action callback more robust
Oaphi Jul 13, 2025
da9fae5
we don't even have trust level 6
Oaphi Jul 13, 2025
12ccb1e
added test for checking that categories with high trust level to view…
Oaphi Jul 13, 2025
72d6bdc
made categories controller :show test cover all cases
Oaphi Jul 13, 2025
baa38f8
added try_create_category test helper method
Oaphi Jul 13, 2025
1270732
cleaned up & expanded categories controller tests
Oaphi Jul 13, 2025
99802f5
let's dry-run CodeCov
Oaphi Jul 13, 2025
c86bd07
working on CodeCov upload actions step
Oaphi Jul 13, 2025
201067b
enabled verbose mode & CI failure on error if CodeCov fails to get co…
Oaphi Jul 13, 2025
b82407f
let's run CodeCov for real this time
Oaphi Jul 13, 2025
d384080
eh, apparently, CodeCov needs coverage output
Oaphi Jul 13, 2025
2f2b6a6
coverage option works too, let's actually upload
Oaphi Jul 13, 2025
247200a
cleaned up posts controller create tests
Oaphi Jul 14, 2025
c193280
Update & test flag mailer
ArtOfCode- Jul 14, 2025
345ca6d
fixed subscriptions remove route call
Oaphi Jul 14, 2025
2fe41f8
oops, that's on me: data-sub-id is a string, not a subscription
Oaphi Jul 14, 2025
90ba05f
Merge pull request #1683 from codidact/0valt/1682/subscriptions-fix
Oaphi Jul 14, 2025
c359b56
Merge branch 'develop' into 0valt/1509/search_tests
Oaphi Jul 14, 2025
5298d77
Upgrade Rails to 7.2
ArtOfCode- Jul 15, 2025
db9f5f4
Update serialize arguments
ArtOfCode- Jul 15, 2025
b369b81
Maybe that?
ArtOfCode- Jul 15, 2025
1aa0fc0
That seemed to work; update the rest of them
ArtOfCode- Jul 15, 2025
55a50b7
Rubocop autofixes
ArtOfCode- Jul 15, 2025
dd6be10
JSON doesn't play nice with existing values
ArtOfCode- Jul 15, 2025
49759de
More rubocop fixes
ArtOfCode- Jul 15, 2025
e98e233
More rubocop fixes
ArtOfCode- Jul 15, 2025
c89838e
Missed some renames
ArtOfCode- Jul 15, 2025
13bd1e6
fixed subscriptions remove route call
Oaphi Jul 14, 2025
8e7ea8a
oops, that's on me: data-sub-id is a string, not a subscription
Oaphi Jul 14, 2025
ea46c7b
Start on testing
ArtOfCode- Jul 15, 2025
18d7498
Thanks rubocop
ArtOfCode- Jul 15, 2025
f4143b0
Merge branch 'develop' into art/1680/flag-escalations
Oaphi Jul 15, 2025
5cb0045
ensured flag mailer test reproduces the 500 error
Oaphi Jul 15, 2025
1ecc64c
fixed generic_share_link always incorrectly linking to default host (…
Oaphi Jul 15, 2025
7d6e6f5
fixed user links in the flag partial always leading to default host (…
Oaphi Jul 15, 2025
50f324e
fixed post history url helper in the flag partial leading to server e…
Oaphi Jul 15, 2025
02e57ed
let's not lump flag_escalated mailer test cases together
Oaphi Jul 15, 2025
d441fda
added comment_user_link to ensure comment user links never link to th…
Oaphi Jul 15, 2025
6035001
added post_user_link to ensure post user links never link to the defa…
Oaphi Jul 15, 2025
d6e3d07
Merge pull request #1686 from codidact/0valt/1680/suggestions
ArtOfCode- Jul 15, 2025
8e0fed9
added a proper partial for rendering post tag badges & ensured they n…
Oaphi Jul 15, 2025
4e445c7
Merge pull request #1687 from codidact/0valt/1680/suggestions
ArtOfCode- Jul 15, 2025
0586748
Merge pull request #1681 from codidact/art/1680/flag-escalations
ArtOfCode- Jul 15, 2025
5856bc5
added generate_thread_title comments helper
Oaphi Jul 16, 2025
c3bb5e3
show pinged usernames in thread titles instead of ping strings
Oaphi Jul 16, 2025
0cdbae4
Merge branch 'develop' into 0valt/1262/thread-titles
Oaphi Jul 16, 2025
1b415ca
abstracted ping string parsing into uid_from_ping comments helper
Oaphi Jul 16, 2025
bd1b8eb
Merge branch 'develop' into art/1684/update-job-iteration
Oaphi Jul 16, 2025
9a4850f
added test ensuring same_as? works against nil values
Oaphi Jul 16, 2025
cb172e4
reflected that same_as? identity concern method is generic in its YARD
Oaphi Jul 16, 2025
06df0b7
switched render_pings's helper self check to same_as?
Oaphi Jul 16, 2025
4cd1b48
optimized user ping rendering:
Oaphi Jul 16, 2025
ef3fa77
removed uid_from_ping in favor of using capture groups
Oaphi Jul 16, 2025
a503b00
inlined pinged_user_ids helper into pinged_users as it's used only once
Oaphi Jul 16, 2025
89c9b18
Merge pull request #1688 from codidact/0valt/1262/thread-titles
ArtOfCode- Jul 17, 2025
7812109
Review suggestion
ArtOfCode- Jul 17, 2025
a7ce276
Merge develop
ArtOfCode- Jul 17, 2025
3ffc9be
Merge branch 'develop' into 0valt/1509/search_tests
Oaphi Jul 17, 2025
ba6b9f0
Some pinned links tests
ArtOfCode- Jul 17, 2025
efcfd9f
Rubocop and forgot the helpers
ArtOfCode- Jul 17, 2025
35d42c2
-_-
ArtOfCode- Jul 17, 2025
3288e02
Specific category test
ArtOfCode- Jul 17, 2025
7ac9de9
Reactions test
ArtOfCode- Jul 17, 2025
d63439c
Close reasons test
ArtOfCode- Jul 17, 2025
aaaa6e8
Update admin-all email strategy
ArtOfCode- Jul 18, 2025
e55da90
Add users mailer and deletion confirmation email
ArtOfCode- Jul 18, 2025
9baaa41
Send email on deletion
ArtOfCode- Jul 18, 2025
6177780
Rubocop and Rails, forever at war
ArtOfCode- Jul 18, 2025
8504624
Exclude unconfirmed users
ArtOfCode- Jul 18, 2025
eff0b66
Specify correct host
ArtOfCode- Jul 18, 2025
18915a3
So we need application as well
ArtOfCode- Jul 18, 2025
797265e
Send while we still have an email address
ArtOfCode- Jul 18, 2025
088e88d
Not sure why that isn't working
ArtOfCode- Jul 18, 2025
18a80fd
Maybe a mailer test?
ArtOfCode- Jul 18, 2025
075577b
Are these missing deleted markers?
ArtOfCode- Jul 18, 2025
e293f99
Revert "Are these missing deleted markers?"
Oaphi Jul 19, 2025
0085d50
let's not spam hundreds of thousands of logs when testing, info is mo…
Oaphi Jul 19, 2025
653aa58
clear_enqueued jobs is needed, or any develiver_later (and potentiall…
Oaphi Jul 19, 2025
e7c48f2
Add community parameter to SiteSetting
ArtOfCode- Jul 20, 2025
54b47a0
Add community parameter to mailers
ArtOfCode- Jul 20, 2025
df505ba
Test updated mailers
ArtOfCode- Jul 20, 2025
4fea80d
Test remaining admin controller methods
ArtOfCode- Jul 20, 2025
d4bdf38
Correct tests
ArtOfCode- Jul 20, 2025
15b337c
fixed send_admin_email & send_all_email's request context (it's threa…
Oaphi Jul 20, 2025
a57ca68
added global versions of NoReplySenderName & NoReplySenderEmail
Oaphi Jul 20, 2025
2694cf9
Set queue adapters to inline in dev and test
ArtOfCode- Jul 20, 2025
8b3d174
Address review comment re network name
ArtOfCode- Jul 20, 2025
a7e0e73
Review suggestions
ArtOfCode- Jul 20, 2025
57d156d
Remove rubocop disables
ArtOfCode- Jul 20, 2025
f42df24
lockfile fixes to prevent nokogiri from downing our Docker setup agai…
Oaphi Jul 20, 2025
6baf8a7
added msgpack to the deps list (ActiveSupport::MessageEncryptor requi…
Oaphi Jul 21, 2025
27b9491
minor cleanup of the AppsController
Oaphi Jul 21, 2025
70d0daf
added first microauth tests (coverage)
Oaphi Jul 21, 2025
55e0e0e
MicroAuth::Token & MicroAuth::App should be cleaned up before users w…
Oaphi Jul 21, 2025
2caaee3
fixed microauth fixtures
Oaphi Jul 21, 2025
bc3e10e
MicroAuth::Token is hard-dependent on MicroAuth::App
Oaphi Jul 21, 2025
2936c19
MicroAuth::App is hard-dependent on User
Oaphi Jul 21, 2025
0ff8f6b
some more microauth app tests
Oaphi Jul 21, 2025
72d8759
added donation mailer test ensuring DonationSenderEmail is set correctly
Oaphi Jul 21, 2025
92402ee
added try_resolve_flag flags controller test helper
Oaphi Jul 21, 2025
961bf93
made flag status test make more sense
Oaphi Jul 21, 2025
cb5dba4
fixed flag fixtures causing some coverage misses
Oaphi Jul 21, 2025
9341de9
added first tests for the authentication microauth controller
Oaphi Jul 21, 2025
bc8a472
added test for the user model's not_blocklisted? callback
Oaphi Jul 21, 2025
cc7871f
added a simple test for the CommunityUser#latest_warning method
Oaphi Jul 21, 2025
866a7b5
Merge pull request #1692 from codidact/0valt/1685/coverage
ArtOfCode- Jul 21, 2025
a01e88e
Merge pull request #1691 from codidact/art/email-changes
ArtOfCode- Jul 21, 2025
1060a7f
Merge branch 'develop' into art/1684/update-job-iteration
ArtOfCode- Jul 21, 2025
f6d566c
Still need :test in test
ArtOfCode- Jul 21, 2025
3129b7c
Hopefully this works
ArtOfCode- Jul 21, 2025
6c6ca8b
Close enough
ArtOfCode- Jul 21, 2025
e0049c9
Thanks rubocop
ArtOfCode- Jul 21, 2025
679d0f2
Add missing abilities
ArtOfCode- Jul 21, 2025
4da11cf
switched send_admin_email to use deliver_later instead of thread wrap…
Oaphi Jul 21, 2025
6418a35
Merge pull request #1685 from codidact/art/1684/update-job-iteration
ArtOfCode- Jul 21, 2025
2b374e6
Merge branch 'develop' into 0valt/1509/search_tests
Oaphi Jul 21, 2025
a7fc02e
bumped rubocop-rake to 0.7.1
Oaphi Jul 21, 2025
b9441e4
size.zero? <=> empty? (Rubocop)
Oaphi Jul 21, 2025
71ddc91
Add model infra for inbound duplicates
ArtOfCode- Jul 21, 2025
e65b7ec
don't allow self-deletion for an account that (still) uses 2fa
cellio Jul 22, 2025
cd176ad
improve coverage for self-deletion of 2FA accounts
Oaphi Jul 22, 2025
f7bebe0
Merge pull request #1696 from codidact/0valt/no-2fa-self-delete-coverage
cellio Jul 22, 2025
fa7f944
Update view to include related posts widget
ArtOfCode- Jul 22, 2025
b5edb7d
Make widgets collapsible
ArtOfCode- Jul 22, 2025
0ae6283
Add collapse user preferences
ArtOfCode- Jul 22, 2025
24b3f8b
Control collapse state from preference
ArtOfCode- Jul 22, 2025
434fcca
Merge pull request #1695 from codidact/cellio/no-2fa-self-delete
cellio Jul 22, 2025
32c2051
Merge branch 'develop' into art/1348/duplicate-links
ArtOfCode- Jul 22, 2025
1c53be6
Merge branch 'develop' into 0valt/1509/search_tests
Oaphi Jul 22, 2025
cc149a5
Merge pull request #1698 from codidact/art/1348/duplicate-links
ArtOfCode- Jul 22, 2025
6b58734
let's see how a merged workflow goes
Oaphi Jul 22, 2025
a8a3a0b
Merge branch 'develop' into 0valt/1509/search_tests
Oaphi Jul 22, 2025
c8e9a70
here goes nothing - testing deployments
Oaphi Jul 22, 2025
dde6596
whoops, yaml...
Oaphi Jul 22, 2025
69046cf
quick test - do we have extra keys in?
Oaphi Jul 22, 2025
14af669
let's see if verbose mode yields anything of use
Oaphi Jul 22, 2025
e57813e
drop base64 decoding & check SSH version
Oaphi Jul 22, 2025
4c7c92d
this ssh command order makes more sense
Oaphi Jul 22, 2025
441e81f
don't even try keyboard & pwd auth
Oaphi Jul 22, 2025
8f4f3d3
restore full pipeline and test
Oaphi Jul 22, 2025
14ce76c
run deploy only on push to develop
Oaphi Jul 22, 2025
9554b26
go away, CircleCI
Oaphi Jul 22, 2025
84638af
renamed main workflow to ci-cd
Oaphi Jul 22, 2025
bd3904e
CircleCI badge is not needed anymore
Oaphi Jul 22, 2025
527c09b
proudly disply the new status badge
Oaphi Jul 22, 2025
682933f
fixed server error when attempting to create threads failing validation
Oaphi Jul 23, 2025
cebb33e
moved new thread modal's char limits to the view's variables section
Oaphi Jul 23, 2025
2ebf341
ensured comment thread textarea is properly validated for max/min con…
Oaphi Jul 23, 2025
670de3e
fixed logic of character_count listener for changes
Oaphi Jul 23, 2025
84446c6
that's not how composite transactions work either... (fixed create_th…
Oaphi Jul 23, 2025
7ab793c
added top_level_post_types scope to Category
Oaphi Jul 23, 2025
230f94a
switched CategoriesController#post_types to top_level_post_types
Oaphi Jul 23, 2025
55a033b
disabled the 'create post' button if there are no available post type…
Oaphi Jul 23, 2025
25eb7a1
allow admins to click on the 'create post' button even if the categor…
Oaphi Jul 23, 2025
8f2facb
admins are now redirected to category post types edit page upon attem…
Oaphi Jul 23, 2025
8279bc2
fixed up the 0 allowed post types case for the category post types vi…
Oaphi Jul 23, 2025
7851d0f
minor cleanup of the comments controller
Oaphi Jul 23, 2025
409b762
fixed updating a comment temporarily showing pings as 'unpingable'
Oaphi Jul 23, 2025
a8d4a69
moved warning that unrelated pings users are not notified to a locale…
Oaphi Jul 23, 2025
07cb550
fixed other cases of comments not accounting for pingable state
Oaphi Jul 23, 2025
29b0054
Merge pull request #1513 from codidact/0valt/1509/search_tests
ArtOfCode- Jul 23, 2025
0d7ae3e
Merge pull request #1702 from codidact/0valt/1389/threads
ArtOfCode- Jul 23, 2025
9d3670c
Merge pull request #1704 from codidact/0valt/categories
ArtOfCode- Jul 23, 2025
a2a7293
Merge pull request #1705 from codidact/0valt/725/comments
ArtOfCode- Jul 23, 2025
be1b887
Bump the bundler group across 1 directory with 2 updates
dependabot[bot] Jul 23, 2025
60b9443
exclude dependabot from coverage upload & deploy (just in case)
Oaphi Jul 23, 2025
05475dd
temporarily restored CodeQL-Build job
Oaphi Jul 23, 2025
3d95e35
oops, forgot the context prefix
Oaphi Jul 23, 2025
eba2731
fixed codeql-analysis config file
Oaphi Jul 23, 2025
f1af205
reupgrade CodeQL-Build to v2
Oaphi Jul 23, 2025
d353b88
even if it's temporary, let's be on our best behavior with CodeQL
Oaphi Jul 23, 2025
98ae102
fine, GHA, you win, no env in 'if' on job level
Oaphi Jul 23, 2025
14bf5db
Merge pull request #1706 from codidact/0valt/test
ArtOfCode- Jul 23, 2025
09e7409
Cheating: update CQL to v3
ArtOfCode- Jul 23, 2025
edb4a2e
Cheating: update permissions
ArtOfCode- Jul 23, 2025
b8edd37
Cheating: update analyze job
ArtOfCode- Jul 23, 2025
0e9b24a
Cheating: make jobs dependent
ArtOfCode- Jul 23, 2025
1938457
Cheating: add write permission
ArtOfCode- Jul 23, 2025
ebfc998
Merge branch 'develop' into dependabot/bundler/bundler-f02c9c4a61
Oaphi Jul 24, 2025
2d3028b
switch nokogiri back to generic version
Oaphi Jul 24, 2025
2b8488c
Testing: default setup?
ArtOfCode- Jul 24, 2025
585632e
Merge branch 'develop' into dependabot/bundler/bundler-f02c9c4a61
Oaphi Jul 24, 2025
a632a47
Merge pull request #1694 from codidact/dependabot/bundler/bundler-f02…
Oaphi Jul 24, 2025
210142d
Merge branch 'master' into develop
ArtOfCode- Jul 24, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
337 changes: 0 additions & 337 deletions .circleci/config.yml

This file was deleted.

Loading
Loading