Skip to content

Fixes for featured (pinned) links#1727

Merged
Oaphi merged 7 commits intodevelopfrom
0valt/pinned_links
Aug 2, 2025
Merged

Fixes for featured (pinned) links#1727
Oaphi merged 7 commits intodevelopfrom
0valt/pinned_links

Conversation

@Oaphi
Copy link
Member

@Oaphi Oaphi commented Aug 2, 2025

closes #1726

This PR fixes two tightly-coupled bugs that we have with pinned links:

  • it's now possible to create pinned links without post id (as expected);
  • creation of pinned links no longer silently fails for invalid links;
  • updating pinned links no longer silently fails when trying to save invalid updates;
  • we now validate that either a post or a URL is set;

This is how attempting to create an inavlid pinned link looks like now:

Screenshot from 2025-08-02 20-16-42

@Oaphi Oaphi requested review from a team, ArtOfCode- and cellio August 2, 2025 17:19
@codecov
Copy link

codecov bot commented Aug 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.66%. Comparing base (8f917b1) to head (e8b5f5f).
⚠️ Report is 10 commits behind head on develop.

Additional details and impacted files
Components Coverage Δ
controllers 68.95% <100.00%> (+0.24%) ⬆️
helpers 79.01% <ø> (ø)
jobs 48.57% <ø> (ø)
models 85.90% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ArtOfCode- ArtOfCode- added this to the v0.12.3 milestone Aug 2, 2025
@Oaphi Oaphi merged commit 78c1f6e into develop Aug 2, 2025
19 of 22 checks passed
@Oaphi Oaphi deleted the 0valt/pinned_links branch August 2, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

It's not possible to create featured (pinned) links that don't have a post

2 participants