Skip to content

Conversation

@Oaphi
Copy link
Member

@Oaphi Oaphi commented Aug 4, 2025

closes #1732

This PR ensures close reason names are validated for both minimum & maximum length (the latter is just so as crafty users aren't "rewarded" with a server error).

It also fixes lack of visible validation errors when trying to update (we've fixed the create action earlier) an invalid close reason:

Screenshot from 2025-08-04 12-11-55

@Oaphi Oaphi added this to the v0.12.3 milestone Aug 4, 2025
@Oaphi Oaphi requested review from a team, ArtOfCode- and cellio August 4, 2025 09:15
@ArtOfCode-
Copy link
Member

Approved but has conflicts.

@Oaphi
Copy link
Member Author

Oaphi commented Aug 4, 2025

Approved but has conflicts.

Yeah, due to #1733 - will solve shortly

@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.80%. Comparing base (00a8551) to head (3f9f144).
⚠️ Report is 11 commits behind head on develop.

Additional details and impacted files
Components Coverage Δ
controllers 69.20% <100.00%> (+0.15%) ⬆️
helpers 79.01% <ø> (ø)
jobs 48.57% <ø> (ø)
models 85.92% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Oaphi Oaphi added the status: blocked This is being worked on but is blocked by something else label Aug 4, 2025
@Oaphi Oaphi removed the status: blocked This is being worked on but is blocked by something else label Aug 4, 2025
@Oaphi Oaphi requested a review from ArtOfCode- August 4, 2025 14:08
@ArtOfCode- ArtOfCode- merged commit 5b71da2 into develop Aug 4, 2025
18 of 22 checks passed
@ArtOfCode- ArtOfCode- deleted the 0valt/1732/close_reasons branch August 4, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

None of the custom close reason fields are validated

2 participants