Skip to content

Conversation

@ArtOfCode-
Copy link
Member

Closes #1738.

@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@16a4657). Learn more about missing BASE report.

⚠️ Current head 82598a3 differs from pull request most recent head 5a2f36a

Please upload reports for the commit 5a2f36a to get more accurate results.

Files with missing lines Patch % Lines
app/models/post_type.rb 66.66% 1 Missing ⚠️
Additional details and impacted files
Components Coverage Δ
controllers 69.90% <100.00%> (?)
helpers 81.82% <ø> (?)
jobs 60.00% <ø> (?)
models 86.12% <80.00%> (?)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ArtOfCode- ArtOfCode- marked this pull request as ready for review August 5, 2025 18:07
@ArtOfCode- ArtOfCode- requested a review from Oaphi August 5, 2025 18:08
@ArtOfCode- ArtOfCode- added this to the v0.13.0 milestone Aug 5, 2025
@Oaphi
Copy link
Member

Oaphi commented Aug 7, 2025

Note for other reviewers (assuming there will be any except me): be careful when switching back & forth between this PR and others, cache must be cleaned every time you switch away from this one (it's expected, just a heads up).

Copy link
Member

@Oaphi Oaphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oaphi Oaphi merged commit ee9e02a into develop Aug 10, 2025
18 checks passed
@Oaphi Oaphi deleted the art/1738/activerecord-caching branch August 10, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle ActiveRecord collection caching properly

2 participants