Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cellio
left a comment
There was a problem hiding this comment.
Tested with <, =, and > limit and works as expected. Most of the code makes sense to me (do get a more qualified reviewer), though the ...flag part on line 458 in the JS file I don't understand at all (my failing not yours). I left a couple comments asking about ways to improve the user feedback; if the answer is "not now" and that would be a separate issue later, that's fine. But if it's easy, can we try to do something here?
cellio
left a comment
There was a problem hiding this comment.
Approved behavior/tests; someone else should also review.
closes #1289
This PR includes the following improvements to flagging:
MaxFlagReasonLength;flags.errors.rate_limitedis added for now, though, to keep the PR simple;