Skip to content

Tour fixes#1778

Merged
Oaphi merged 2 commits intodevelopfrom
0valt/1777/tour-editor
Aug 13, 2025
Merged

Tour fixes#1778
Oaphi merged 2 commits intodevelopfrom
0valt/1777/tour-editor

Conversation

@Oaphi
Copy link
Member

@Oaphi Oaphi commented Aug 13, 2025

closes #1777
closes #247

In addition to fixing a runtime error breaking modals on the tour page, this PR also fixes overflow of the tour hints content on narrow screens - we now move the hints section to the top when the breakpoint is reach (when we can, we should also collapse them in such cases, but it's a "good enough" solution for the time being):

Screenshot from 2025-08-13 04-13-19

@Oaphi Oaphi added this to the v0.12.4 milestone Aug 13, 2025
@Oaphi Oaphi requested review from a team and cellio August 13, 2025 01:17
@Oaphi Oaphi changed the title 0valt/1777/tour editor Tour fixes Aug 13, 2025
@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@ee9e02a). Learn more about missing BASE report.
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
Components Coverage Δ
controllers 70.11% <ø> (?)
helpers 81.88% <ø> (?)
jobs 60.00% <ø> (?)
models 86.12% <ø> (?)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@cellio cellio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed that image upload works and the layout adjusts for small viewports.

@Oaphi Oaphi merged commit a78615d into develop Aug 13, 2025
13 checks passed
@Oaphi Oaphi deleted the 0valt/1777/tour-editor branch August 13, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Image upload does not work in the tour's editor Tour is too squished to be readable on phones

2 participants