Skip to content

Fix for required tags duplication & improvements to tag renaming#1782

Merged
Oaphi merged 3 commits intodevelopfrom
0valt/939/tags
Aug 14, 2025
Merged

Fix for required tags duplication & improvements to tag renaming#1782
Oaphi merged 3 commits intodevelopfrom
0valt/939/tags

Conversation

@Oaphi
Copy link
Member

@Oaphi Oaphi commented Aug 13, 2025

closes #939

Given that the fix is extremely minor, I've thrown in a couple of improvements to tag renaming, specifically, aligned the JSON response structure with the other methods (part of #1754) + the failure message is now server-side.

Note to reviewers: new locale string files are only picked up by Rails servers only after reload

@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.33%. Comparing base (9bf4235) to head (1c4e61b).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files
Components Coverage Δ
controllers 70.33% <100.00%> (+0.02%) ⬆️
helpers 81.92% <ø> (ø)
jobs 60.00% <ø> (ø)
models 86.29% <ø> (ø)
tasks 61.11% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Oaphi Oaphi requested review from a team, ArtOfCode- and cellio August 13, 2025 23:17
@Oaphi Oaphi modified the milestones: v0.12.3, v0.12.4 Aug 13, 2025
Copy link
Member

@cellio cellio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tags no longer duplicate (for either edits or suggested edits). It looks like the other changes are internal, or at least I couldn't figure out a user-visible change that I could test manually.

@Oaphi
Copy link
Member Author

Oaphi commented Aug 14, 2025

It looks like the other changes are internal

Yeah, no user-visible changes have been made to tag renaming, just a bit of cleanup in preparation for #1754

@Oaphi Oaphi merged commit 38ad693 into develop Aug 14, 2025
13 checks passed
@Oaphi Oaphi deleted the 0valt/939/tags branch August 14, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When editing tags, clicking on a required tag adds it again

3 participants